Mailing-List: contact common-issues-help@hadoop.apache.org; run by ezmlm
Precedence: bulk
Reply-To: common-issues@hadoop.apache.org
Message-ID: <7831998.33651288973563880.JavaMail.jira@thor>
Date: Fri, 5 Nov 2010 12:12:43 -0400 (EDT)
From: "Hadoop QA (JIRA)" <jira@apache.org>
To: common-issues@hadoop.apache.org
Subject: [jira] Commented: (HADOOP-6194) Add service base class and tests to
 hadoop-common/util
In-Reply-To: <165334509.1250255474864.JavaMail.jira@brutus>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit


    [ https://issues.apache.org/jira/browse/HADOOP-6194?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12928647#action_12928647 ] 

Hadoop QA commented on HADOOP-6194:
-----------------------------------

-1 overall.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12443133/find-new-warnings
  against trunk revision 1031422.

    +1 @author.  The patch does not contain any @author tags.

    -1 tests included.  The patch doesn't appear to include any new or modified tests.
                        Please justify why no new tests are needed for this patch.
                        Also please list what manual steps were performed to verify this patch.

    -1 patch.  The patch command could not apply the patch.

Console output: https://hudson.apache.org/hudson/job/PreCommit-HADOOP-Build/71//console

This message is automatically generated.

> Add service base class and tests to hadoop-common/util
> ------------------------------------------------------
>
>                 Key: HADOOP-6194
>                 URL: https://issues.apache.org/jira/browse/HADOOP-6194
>             Project: Hadoop Common
>          Issue Type: New Feature
>          Components: util
>    Affects Versions: 0.21.0
>            Reporter: Steve Loughran
>            Assignee: Steve Loughran
>             Fix For: 0.22.0
>
>         Attachments: find-new-warnings, HADOOP-6194-1.patch, HADOOP-6194.patch, HADOOP-6194.patch
>
>
> For a service base class, we need to add to common
> # The Service class
> # A mock Service class (it's not in test, its in src/, because it helps in functional tests downstream)
> # Unit tests
> This is the issue to cover this work

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.