Return-Path: Delivered-To: apmail-hadoop-common-issues-archive@minotaur.apache.org Received: (qmail 41252 invoked from network); 19 Nov 2010 01:33:09 -0000 Received: from unknown (HELO mail.apache.org) (140.211.11.3) by 140.211.11.9 with SMTP; 19 Nov 2010 01:33:09 -0000 Received: (qmail 13077 invoked by uid 500); 19 Nov 2010 01:33:40 -0000 Delivered-To: apmail-hadoop-common-issues-archive@hadoop.apache.org Received: (qmail 13039 invoked by uid 500); 19 Nov 2010 01:33:40 -0000 Mailing-List: contact common-issues-help@hadoop.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: common-issues@hadoop.apache.org Delivered-To: mailing list common-issues@hadoop.apache.org Received: (qmail 13031 invoked by uid 99); 19 Nov 2010 01:33:40 -0000 Received: from athena.apache.org (HELO athena.apache.org) (140.211.11.136) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 19 Nov 2010 01:33:40 +0000 X-ASF-Spam-Status: No, hits=-2000.0 required=10.0 tests=ALL_TRUSTED X-Spam-Check-By: apache.org Received: from [140.211.11.22] (HELO thor.apache.org) (140.211.11.22) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 19 Nov 2010 01:33:40 +0000 Received: from thor (localhost [127.0.0.1]) by thor.apache.org (8.13.8+Sun/8.13.8) with ESMTP id oAJ1XJK4006876 for ; Fri, 19 Nov 2010 01:33:20 GMT Message-ID: <3130288.186901290130399770.JavaMail.jira@thor> Date: Thu, 18 Nov 2010 20:33:19 -0500 (EST) From: "Arun C Murthy (JIRA)" To: common-issues@hadoop.apache.org Subject: [jira] Commented: (HADOOP-6685) Change the generic serialization framework API to use serialization-specific bytes instead of Map for configuration MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/HADOOP-6685?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12933647#action_12933647 ] Arun C Murthy commented on HADOOP-6685: --------------------------------------- {quote} I do not agree that an array of bytes is a better way to represent serialization metadata. (I stated this in the first comment on this issue.) I prefer the solutions that were in HADOOP-6165 and HADOOP-6420. My objections are: {quote} Doug, thanks for re-voicing your concerns. The primary objection to HADOOP-6165 was it's implementation and we had a very, very drawn out discussion in MAPREDUCE-1126. The primary reason for taking the current approach was to support serialization in a more explicit, type-safe manner. We have had several discussions on this same topic and I do not see how we can make progress on this anymore. I think we should either agree on the approach or veto this and stop work on this altogether. As has been noted before, progress on this work will greatly benefit Map-Reduce by supporting serialized job descriptions: MAPREDUCE-1183. {quote} I also will re-voice my objection that the current patch makes a large number of changes beyond changing the format of serialization metadata. We should restrict the patch to the description, and change other things in other issues. {quote} Fair point. Using a development branch for this would have been the right approach. We can still do that. However, this patch has progressed to the point that it would be ready to merge-in to the mainline. Again, I think we should, as a community, decide on the direction and either commit this or stop working on it. I do not see how arguing further helps either the atmosphere or the community. > Change the generic serialization framework API to use serialization-specific bytes instead of Map for configuration > ---------------------------------------------------------------------------------------------------------------------------------- > > Key: HADOOP-6685 > URL: https://issues.apache.org/jira/browse/HADOOP-6685 > Project: Hadoop Common > Issue Type: Improvement > Reporter: Owen O'Malley > Assignee: Owen O'Malley > Fix For: 0.22.0 > > Attachments: libthrift.jar, serial.patch, serial4.patch, serial6.patch, serial7.patch, SerializationAtSummit.pdf > > > Currently, the generic serialization framework uses Map for the serialization specific configuration. Since this data is really internal to the specific serialization, I think we should change it to be an opaque binary blob. This will simplify the interface for defining specific serializations for different contexts (MAPREDUCE-1462). It will also move us toward having serialized objects for Mappers, Reducers, etc (MAPREDUCE-1183). -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.