Return-Path: Delivered-To: apmail-hadoop-common-issues-archive@minotaur.apache.org Received: (qmail 69579 invoked from network); 15 Nov 2010 07:52:05 -0000 Received: from unknown (HELO mail.apache.org) (140.211.11.3) by 140.211.11.9 with SMTP; 15 Nov 2010 07:52:05 -0000 Received: (qmail 41964 invoked by uid 500); 15 Nov 2010 07:52:36 -0000 Delivered-To: apmail-hadoop-common-issues-archive@hadoop.apache.org Received: (qmail 41511 invoked by uid 500); 15 Nov 2010 07:52:36 -0000 Mailing-List: contact common-issues-help@hadoop.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: common-issues@hadoop.apache.org Delivered-To: mailing list common-issues@hadoop.apache.org Received: (qmail 41283 invoked by uid 99); 15 Nov 2010 07:52:34 -0000 Received: from athena.apache.org (HELO athena.apache.org) (140.211.11.136) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 15 Nov 2010 07:52:34 +0000 X-ASF-Spam-Status: No, hits=-2000.0 required=10.0 tests=ALL_TRUSTED X-Spam-Check-By: apache.org Received: from [140.211.11.22] (HELO thor.apache.org) (140.211.11.22) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 15 Nov 2010 07:52:34 +0000 Received: from thor (localhost [127.0.0.1]) by thor.apache.org (8.13.8+Sun/8.13.8) with ESMTP id oAF7qE1v002241 for ; Mon, 15 Nov 2010 07:52:14 GMT Message-ID: <29054049.79471289807534386.JavaMail.jira@thor> Date: Mon, 15 Nov 2010 02:52:14 -0500 (EST) From: "Hudson (JIRA)" To: common-issues@hadoop.apache.org Subject: [jira] Commented: (HADOOP-7032) Assert type constraints in the FileStatus constructor In-Reply-To: <27330781.57521289626093694.JavaMail.jira@thor> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/HADOOP-7032?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12932006#action_12932006 ] Hudson commented on HADOOP-7032: -------------------------------- Integrated in Hadoop-Common-trunk-Commit #425 (See [https://hudson.apache.org/hudson/job/Hadoop-Common-trunk-Commit/425/]) > Assert type constraints in the FileStatus constructor > ----------------------------------------------------- > > Key: HADOOP-7032 > URL: https://issues.apache.org/jira/browse/HADOOP-7032 > Project: Hadoop Common > Issue Type: Improvement > Components: fs > Reporter: Eli Collins > Assignee: Eli Collins > Fix For: 0.22.0 > > Attachments: hadoop-7032-1.patch > > > A FileStatus may represent a file, directory or symlink. This is indicated using the isdir and symlink members, let's add an assert that validates the contstraints on these members (eg a directory may not have the symlink member set). We could also verify this by having more than one constructor but we don't statically know the type of the file status when we create it. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.