hadoop-common-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hadoop QA (JIRA)" <j...@apache.org>
Subject [jira] Commented: (HADOOP-6578) Configuration should trim whitespace around a lot of value types
Date Fri, 05 Nov 2010 16:28:56 GMT

    [ https://issues.apache.org/jira/browse/HADOOP-6578?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12928659#action_12928659
] 

Hadoop QA commented on HADOOP-6578:
-----------------------------------

-1 overall.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12438609/HADOOP-6578.patch
  against trunk revision 1031422.

    +1 @author.  The patch does not contain any @author tags.

    +1 tests included.  The patch appears to include 3 new or modified tests.

    -1 javadoc.  The javadoc tool appears to have generated 1 warning messages.

    +1 javac.  The applied patch does not increase the total number of javac compiler warnings.

    +1 findbugs.  The patch does not introduce any new Findbugs warnings.

    +1 release audit.  The applied patch does not increase the total number of release audit
warnings.

    +1 core tests.  The patch passed core unit tests.

    +1 contrib tests.  The patch passed contrib unit tests.

    +1 system test framework.  The patch passed system test framework compile.

Test results: https://hudson.apache.org/hudson/job/PreCommit-HADOOP-Build/61//testReport/
Findbugs warnings: https://hudson.apache.org/hudson/job/PreCommit-HADOOP-Build/61//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Console output: https://hudson.apache.org/hudson/job/PreCommit-HADOOP-Build/61//console

This message is automatically generated.

> Configuration should trim whitespace around a lot of value types
> ----------------------------------------------------------------
>
>                 Key: HADOOP-6578
>                 URL: https://issues.apache.org/jira/browse/HADOOP-6578
>             Project: Hadoop Common
>          Issue Type: Improvement
>          Components: conf
>    Affects Versions: 0.22.0
>            Reporter: Todd Lipcon
>            Assignee: Michele Catasta
>            Priority: Minor
>         Attachments: HADOOP-6578.patch
>
>
> I've seen multiple users make an error where they've listed some whitespace around a
class name (eg for configuring a scheduler). This results in a ClassNotFoundException which
is very hard to debug, as you don't notice the whitespace in the exception! We should simply
trim the whitespace in Configuration.getClass and Configuration.getClasses to avoid this class
of user error.
> Similarly, we should trim in getInt, getLong, etc - anywhere that whitespace doesn't
have semantic meaning we should be a little less strict on input.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message