[ https://issues.apache.org/jira/browse/HADOOP-6562?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12931997#action_12931997
]
Konstantin Boudnik commented on HADOOP-6562:
--------------------------------------------
Except for a couple white-space changes like
{noformat}
public static String getAbsoluteTestRootDir(FileContext fc)
- throws IOException {
+ throws IOException {
{noformat}
and
{noformat}
public static void createFileNonRecursive(FileContext fc, String name)
- throws IOException {
+ throws IOException {
{noformat}
the rest looks good.
+1 patch looks good conditional to the white-space changes removal. I don't think new patch
needs to be re-validated.
> FileContextSymlinkBaseTest should use FileContextTestHelper
> -----------------------------------------------------------
>
> Key: HADOOP-6562
> URL: https://issues.apache.org/jira/browse/HADOOP-6562
> Project: Hadoop Common
> Issue Type: Improvement
> Components: test
> Affects Versions: 0.22.0
> Reporter: Eli Collins
> Assignee: Eli Collins
> Priority: Minor
> Fix For: 0.22.0
>
> Attachments: hadoop-6562-1.patch
>
>
> FileContextSymlinkBaseTest should use FileContextTestHelper, both for utility methods
and defining the root test directory instead of using /tmp.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
|