hadoop-common-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Todd Lipcon (JIRA)" <j...@apache.org>
Subject [jira] Commented: (HADOOP-7032) Assert type constraints in the FileStatus constructor
Date Sat, 13 Nov 2010 09:30:15 GMT

    [ https://issues.apache.org/jira/browse/HADOOP-7032?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12931646#action_12931646
] 

Todd Lipcon commented on HADOOP-7032:
-------------------------------------

+1 assuming test-core ran cleanly even with assertions enabled (I don't think we've committed
the -ea patch yet to HDFS, have we?)

> Assert type constraints in the FileStatus constructor
> -----------------------------------------------------
>
>                 Key: HADOOP-7032
>                 URL: https://issues.apache.org/jira/browse/HADOOP-7032
>             Project: Hadoop Common
>          Issue Type: Improvement
>          Components: fs
>            Reporter: Eli Collins
>            Assignee: Eli Collins
>             Fix For: 0.22.0
>
>         Attachments: hadoop-7032-1.patch
>
>
> A FileStatus may represent a file, directory or symlink.  This is indicated using the
isdir and symlink members, let's add an assert that validates the contstraints on these members
(eg a directory may not have the symlink member set).  We could also verify this by having
more than one constructor but we don't statically know the type of the file status when we
create it.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message