hadoop-common-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hadoop QA (JIRA)" <j...@apache.org>
Subject [jira] Commented: (HADOOP-7038) saveVersion script includes an additional \r while running whoami under windows
Date Tue, 16 Nov 2010 23:17:13 GMT

    [ https://issues.apache.org/jira/browse/HADOOP-7038?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12932710#action_12932710
] 

Hadoop QA commented on HADOOP-7038:
-----------------------------------

-1 overall.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12459738/HADOOP-7038.diff
  against trunk revision 1035353.

    +1 @author.  The patch does not contain any @author tags.

    -1 tests included.  The patch doesn't appear to include any new or modified tests.
                        Please justify why no new tests are needed for this patch.
                        Also please list what manual steps were performed to verify this patch.

    +1 javadoc.  The javadoc tool did not generate any warning messages.

    +1 javac.  The applied patch does not increase the total number of javac compiler warnings.

    +1 findbugs.  The patch does not introduce any new Findbugs warnings.

    +1 release audit.  The applied patch does not increase the total number of release audit
warnings.

    +1 core tests.  The patch passed core unit tests.

    +1 contrib tests.  The patch passed contrib unit tests.

    +1 system test framework.  The patch passed system test framework compile.

Test results: https://hudson.apache.org/hudson/job/PreCommit-HADOOP-Build/105//testReport/
Findbugs warnings: https://hudson.apache.org/hudson/job/PreCommit-HADOOP-Build/105//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Console output: https://hudson.apache.org/hudson/job/PreCommit-HADOOP-Build/105//console

This message is automatically generated.

> saveVersion script includes an additional \r while running whoami under windows
> -------------------------------------------------------------------------------
>
>                 Key: HADOOP-7038
>                 URL: https://issues.apache.org/jira/browse/HADOOP-7038
>             Project: Hadoop Common
>          Issue Type: Bug
>          Components: build
>         Environment: Windows 7 / Eclipse 
>            Reporter: Wang Xu
>            Assignee: Wang Xu
>            Priority: Minor
>         Attachments: HADOOP-7038.diff
>
>
> I built common under windows occasionally, and found it failed because the 'user' in
build/src/o/a/h/package-info.java is "myhostmyname^M".
> It seems because the whoami of windows give a string with '\n\r' rather than '\n' only.
thus I add an additional tr for it to eliminate the problem.
> Since only windows would generate '\n\r' output, I think it won't harm to any other platform.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message