hadoop-common-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Konstantin Boudnik (JIRA)" <j...@apache.org>
Subject [jira] Commented: (HADOOP-7038) saveVersion script includes an additional \r while running whoami under windows
Date Wed, 17 Nov 2010 20:16:13 GMT

    [ https://issues.apache.org/jira/browse/HADOOP-7038?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12933127#action_12933127
] 

Konstantin Boudnik commented on HADOOP-7038:
--------------------------------------------

On Unix pre-patched and after patched version produce the same results:

before {{0000000 6f63 0a73}} and after {{0000000 6f63 0a73}}

+1 patch looks good.

It doesn't have any tests for an apparent enough reason.

> saveVersion script includes an additional \r while running whoami under windows
> -------------------------------------------------------------------------------
>
>                 Key: HADOOP-7038
>                 URL: https://issues.apache.org/jira/browse/HADOOP-7038
>             Project: Hadoop Common
>          Issue Type: Bug
>          Components: build
>         Environment: Windows 7 / Eclipse 
>            Reporter: Wang Xu
>            Assignee: Wang Xu
>            Priority: Minor
>         Attachments: HADOOP-7038.diff
>
>
> I built common under windows occasionally, and found it failed because the 'user' in
build/src/o/a/h/package-info.java is "myhostmyname^M".
> It seems because the whoami of windows give a string with '\n\r' rather than '\n' only.
thus I add an additional tr for it to eliminate the problem.
> Since only windows would generate '\n\r' output, I think it won't harm to any other platform.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message