hadoop-common-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Eli Collins (JIRA)" <j...@apache.org>
Subject [jira] Commented: (HADOOP-7052) misspelling of threshold in conf/log4j.properties
Date Sun, 28 Nov 2010 21:35:37 GMT

    [ https://issues.apache.org/jira/browse/HADOOP-7052?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12964593#action_12964593

Eli Collins commented on HADOOP-7052:

     [exec] -1 overall.  
     [exec]     +1 @author.  The patch does not contain any @author tags.
     [exec]     -1 tests included.  The patch doesn't appear to include any new or modified
     [exec]                         Please justify why no new tests are needed for this patch.
     [exec]                         Also please list what manual steps were performed to verify
this patch.
     [exec]     +1 javadoc.  The javadoc tool did not generate any warning messages.
     [exec]     +1 javac.  The applied patch does not increase the total number of javac compiler
     [exec]     +1 findbugs.  The patch does not introduce any new Findbugs (version 1.3.9)
     [exec]     +1 release audit.  The applied patch does not increase the total number of
release audit warnings.
     [exec]     +1 system test framework.  The patch passed system test framework compile.

Don't think this patch needs to include a test.

> misspelling of threshold in conf/log4j.properties
> -------------------------------------------------
>                 Key: HADOOP-7052
>                 URL: https://issues.apache.org/jira/browse/HADOOP-7052
>             Project: Hadoop Common
>          Issue Type: Bug
>          Components: conf
>    Affects Versions: 0.21.0
>            Reporter: Jingguo Yao
>         Attachments: HADOOP-7052.patch
>   Original Estimate: 0.08h
>  Remaining Estimate: 0.08h
> In "log4j.threshhold=ALL", threshhold is a misspelling of threshold. So "log4j.threshhold=ALL"
has no effect on the control of log4j logging.

This message is automatically generated by JIRA.
You can reply to this email to add a comment to the issue online.

View raw message