hadoop-common-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hadoop QA (JIRA)" <j...@apache.org>
Subject [jira] Commented: (HADOOP-7032) Assert type constraints in the FileStatus constructor
Date Sun, 14 Nov 2010 07:24:14 GMT

    [ https://issues.apache.org/jira/browse/HADOOP-7032?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12931778#action_12931778
] 

Hadoop QA commented on HADOOP-7032:
-----------------------------------

-1 overall.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12459517/hadoop-7032-1.patch
  against trunk revision 1034480.

    +1 @author.  The patch does not contain any @author tags.

    -1 tests included.  The patch doesn't appear to include any new or modified tests.
                        Please justify why no new tests are needed for this patch.
                        Also please list what manual steps were performed to verify this patch.

    +1 javadoc.  The javadoc tool did not generate any warning messages.

    +1 javac.  The applied patch does not increase the total number of javac compiler warnings.

    +1 findbugs.  The patch does not introduce any new Findbugs warnings.

    +1 release audit.  The applied patch does not increase the total number of release audit
warnings.

    +1 core tests.  The patch passed core unit tests.

    +1 contrib tests.  The patch passed contrib unit tests.

    +1 system test framework.  The patch passed system test framework compile.

Test results: https://hudson.apache.org/hudson/job/PreCommit-HADOOP-Build/100//testReport/
Findbugs warnings: https://hudson.apache.org/hudson/job/PreCommit-HADOOP-Build/100//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Console output: https://hudson.apache.org/hudson/job/PreCommit-HADOOP-Build/100//console

This message is automatically generated.

> Assert type constraints in the FileStatus constructor
> -----------------------------------------------------
>
>                 Key: HADOOP-7032
>                 URL: https://issues.apache.org/jira/browse/HADOOP-7032
>             Project: Hadoop Common
>          Issue Type: Improvement
>          Components: fs
>            Reporter: Eli Collins
>            Assignee: Eli Collins
>             Fix For: 0.22.0
>
>         Attachments: hadoop-7032-1.patch
>
>
> A FileStatus may represent a file, directory or symlink.  This is indicated using the
isdir and symlink members, let's add an assert that validates the contstraints on these members
(eg a directory may not have the symlink member set).  We could also verify this by having
more than one constructor but we don't statically know the type of the file status when we
create it.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message