hadoop-common-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hadoop QA (JIRA)" <j...@apache.org>
Subject [jira] Commented: (HADOOP-6376) slaves file to have a header specifying the format of conf/slaves file
Date Fri, 05 Nov 2010 16:28:57 GMT

    [ https://issues.apache.org/jira/browse/HADOOP-6376?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12928660#action_12928660
] 

Hadoop QA commented on HADOOP-6376:
-----------------------------------

-1 overall.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12425162/HADOOP-6376.patch
  against trunk revision 1031422.

    +1 @author.  The patch does not contain any @author tags.

    -1 tests included.  The patch doesn't appear to include any new or modified tests.
                        Please justify why no new tests are needed for this patch.
                        Also please list what manual steps were performed to verify this patch.

    +1 javadoc.  The javadoc tool did not generate any warning messages.

    +1 javac.  The applied patch does not increase the total number of javac compiler warnings.

    +1 findbugs.  The patch does not introduce any new Findbugs warnings.

    +1 release audit.  The applied patch does not increase the total number of release audit
warnings.

    +1 core tests.  The patch passed core unit tests.

    +1 contrib tests.  The patch passed contrib unit tests.

    +1 system test framework.  The patch passed system test framework compile.

Test results: https://hudson.apache.org/hudson/job/PreCommit-HADOOP-Build/64//testReport/
Findbugs warnings: https://hudson.apache.org/hudson/job/PreCommit-HADOOP-Build/64//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Console output: https://hudson.apache.org/hudson/job/PreCommit-HADOOP-Build/64//console

This message is automatically generated.

> slaves file to have a header specifying the format of conf/slaves file 
> -----------------------------------------------------------------------
>
>                 Key: HADOOP-6376
>                 URL: https://issues.apache.org/jira/browse/HADOOP-6376
>             Project: Hadoop Common
>          Issue Type: Improvement
>          Components: conf
>    Affects Versions: 0.20.1
>            Reporter: Kay Kay
>            Priority: Minor
>         Attachments: HADOOP-6376.patch
>
>
> When we open the file conf/slaves - it is not immediately obvious what the format of
the file is ( a comma-separated list or one per each line). The docs confirm it is 1 per line.

> Specifying the information by means of a comment in the template so that it is easy to
modify the same, and self-explanatory. 

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message