hadoop-common-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Konstantin Boudnik (JIRA)" <j...@apache.org>
Subject [jira] Updated: (HADOOP-7014) Generalize CLITest structure and interfaces to faciliate upstream adoption (e.g. for web testing)
Date Fri, 12 Nov 2010 03:03:14 GMT

     [ https://issues.apache.org/jira/browse/HADOOP-7014?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Konstantin Boudnik updated HADOOP-7014:
---------------------------------------

    Attachment: HADOOP-6977.patch

util.* test replaces a bunch of otherwise explicit imports. I don't like too many explicit
imports (after some point they start being messy) but I want to make an issue over it. Technically
you are correct: patches shouldn't have unnecessary import mods.

The reason the interface is called CmdTest is that otherwise JUnit (in our configuration)
will consider it to be a test class and will try to run it. However, I agree that the name
is awkward. I have change it to iCmdTest so now it seems to be more clear. Thanks for catching
it up.

Attached patch is full equivalent of the previous one modulo interface name change, I have
re-ran TestCLI and it passes Ok.

> Generalize CLITest structure and interfaces to faciliate upstream adoption (e.g. for
web testing)
> -------------------------------------------------------------------------------------------------
>
>                 Key: HADOOP-7014
>                 URL: https://issues.apache.org/jira/browse/HADOOP-7014
>             Project: Hadoop Common
>          Issue Type: Improvement
>          Components: test
>    Affects Versions: 0.22.0
>            Reporter: Konstantin Boudnik
>            Assignee: Konstantin Boudnik
>         Attachments: HADOOP-6977.patch, HADOOP-7014.patch
>
>
> There's at least one use case where TestCLI infrastructure is helpful for testing projects
outside of core Hadoop (e.g. Owl web testing). In order to make this acceptance easier for
upstream project TestCLI needs to be refactored.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message