Return-Path: Delivered-To: apmail-hadoop-common-issues-archive@minotaur.apache.org Received: (qmail 81449 invoked from network); 5 Oct 2010 00:00:58 -0000 Received: from unknown (HELO mail.apache.org) (140.211.11.3) by 140.211.11.9 with SMTP; 5 Oct 2010 00:00:58 -0000 Received: (qmail 52289 invoked by uid 500); 5 Oct 2010 00:00:58 -0000 Delivered-To: apmail-hadoop-common-issues-archive@hadoop.apache.org Received: (qmail 51877 invoked by uid 500); 5 Oct 2010 00:00:57 -0000 Mailing-List: contact common-issues-help@hadoop.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: common-issues@hadoop.apache.org Delivered-To: mailing list common-issues@hadoop.apache.org Received: (qmail 51869 invoked by uid 99); 5 Oct 2010 00:00:57 -0000 Received: from nike.apache.org (HELO nike.apache.org) (192.87.106.230) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 05 Oct 2010 00:00:57 +0000 X-ASF-Spam-Status: No, hits=-2000.0 required=10.0 tests=ALL_TRUSTED X-Spam-Check-By: apache.org Received: from [140.211.11.22] (HELO thor.apache.org) (140.211.11.22) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 05 Oct 2010 00:00:55 +0000 Received: from thor (localhost [127.0.0.1]) by thor.apache.org (8.13.8+Sun/8.13.8) with ESMTP id o9500X8q005262 for ; Tue, 5 Oct 2010 00:00:33 GMT Message-ID: <30428642.540261286236833649.JavaMail.jira@thor> Date: Mon, 4 Oct 2010 20:00:33 -0400 (EDT) From: "Jakob Homan (JIRA)" To: common-issues@hadoop.apache.org Subject: [jira] Commented: (HADOOP-6987) Use JUnit Rule to optionally fail test cases that run more than 10 seconds In-Reply-To: <26687627.538921286230953013.JavaMail.jira@thor> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 X-Virus-Checked: Checked by ClamAV on apache.org [ https://issues.apache.org/jira/browse/HADOOP-6987?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12917825#action_12917825 ] Jakob Homan commented on HADOOP-6987: ------------------------------------- Not getting my hopes up about Hudson. Tests all pass except known-bad TestSetFile (HADOOP-6989). Test-patch is good: {noformat} [exec] +1 overall. [exec] [exec] +1 @author. The patch does not contain any @author tags. [exec] [exec] +1 tests included. The patch appears to include 5 new or modified tests. [exec] [exec] +1 javadoc. The javadoc tool did not generate any warning messages. [exec] [exec] +1 javac. The applied patch does not increase the total number of javac compiler warnings. [exec] [exec] +1 findbugs. The patch does not introduce any new Findbugs warnings. [exec] [exec] +1 release audit. The applied patch does not increase the total number of release audit warnings. [exec] [exec] +1 system tests framework. The patch passed system tests framework compile.{noformat} > Use JUnit Rule to optionally fail test cases that run more than 10 seconds > -------------------------------------------------------------------------- > > Key: HADOOP-6987 > URL: https://issues.apache.org/jira/browse/HADOOP-6987 > Project: Hadoop Common > Issue Type: Improvement > Components: test > Affects Versions: 0.21.0 > Reporter: Jakob Homan > Assignee: Jakob Homan > Fix For: 0.22.0 > > Attachments: HADOOP-6897.patch > > > Using JUnit Rules annotations we can fail tests cases that take longer than 10 seconds (for instance) to run. This provides a regression check against test cases taking longer than they had previously due to unintended code changes, as well as provides a membership criteria for unit tests versus integration tests in HDFS and MR. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.