hadoop-common-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Giridharan Kesavan (JIRA)" <j...@apache.org>
Subject [jira] Commented: (HADOOP-7008) Enable test-patch.sh to have a configured number of acceptable findbugs and javadoc warnings
Date Thu, 28 Oct 2010 04:47:20 GMT

    [ https://issues.apache.org/jira/browse/HADOOP-7008?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12925687#action_12925687
] 

Giridharan Kesavan commented on HADOOP-7008:
--------------------------------------------

comments:

1) we should add OK_RELEASEAUDIT_WARNINGS to the properties file.. 

2) Every project should define these numbers even if the project has zero warnings for findbugs/releaseaudit/javadoc.
Thatway we dont have to pre-build the trunk to determine the numbers.

3) HADOOP-7008.patch patch seem to run findbug on trunk if the OK_FINDBUGS_WARNINGS is not
defined or the warnings not equal to zero.
Is there any reason why we are running findbugs if its already defined?  

I think all the projects should just define the values for these 3 properties. test-patch.sh
should directly apply the patch and determine the warnings and do a +1 or -1 (if the numbers
are greater than the numbers defined in the properties file.) 



> Enable test-patch.sh to have a configured number of acceptable findbugs and javadoc warnings
> --------------------------------------------------------------------------------------------
>
>                 Key: HADOOP-7008
>                 URL: https://issues.apache.org/jira/browse/HADOOP-7008
>             Project: Hadoop Common
>          Issue Type: Improvement
>          Components: test
>            Reporter: Nigel Daley
>         Attachments: HADOOP-7008.patch
>
>
> test-patch.sh should be able to accept a properties file containing an acceptable number
of findbugs and javadoc warnings.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message