hadoop-common-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Tanping Wang (JIRA)" <j...@apache.org>
Subject [jira] Commented: (HADOOP-6977) Herriot daemon clients should vend statistics
Date Thu, 07 Oct 2010 00:51:32 GMT

    [ https://issues.apache.org/jira/browse/HADOOP-6977?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12918751#action_12918751
] 

Tanping Wang commented on HADOOP-6977:
--------------------------------------

# I looked at HADOOP-6977.patch.  Overall I think it is good.  One concern that I had was
that in the methods of 
-- getJmxPortNumber() 
and
-- isJmxEnabled() , 

"HADOOP_OPTS" was hard-coded and searched.  

This require us to enable remote JMX by putting all the JMX options into HADOOP_OPTS.  In
fact, we can enable JMX ( with specific port number ) by modifying command specific options,
e.g.

# Command specific options appended to HADOOP_OPTS when specified
export HADOOP_NAMENODE_OPTS="-Dcom.sun.management.jmxremote $HADOOP_NAMENODE_OPTS -Dcom.sun.management.jmxremote.port=8004″
export HADOOP_SECONDARYNAMENODE_OPTS="-Dcom.sun.management.jmxremote $HADOOP_SECONDARYNAMENODE_OPTS
-Dcom.sun.management.jmxremote.port=8005″
export HADOOP_DATANODE_OPTS="-Dcom.sun.management.jmxremote $HADOOP_DATANODE_OPTS -Dcom.sun.management.jmxremote.port=8006″
export HADOOP_BALANCER_OPTS="-Dcom.sun.management.jmxremote $HADOOP_BALANCER_OPTS -Dcom.sun.management.jmxremote.port=8007″
export HADOOP_JOBTRACKER_OPTS="-Dcom.sun.management.jmxremote $HADOOP_JOBTRACKER_OPTS -Dcom.sun.management.jmxremote.port=8008″
export HADOOP_TASKTRACKER_OPTS="-Dcom.sun.management.jmxremote.port=8009″


There is also a typo
/** 
Create connection with the remove JMX server at given host and port

I believe you mean remote but not remove?

# FinderTest.java
This test should be refactor to follow Junit 4 ?



> Herriot daemon clients should vend statistics
> ---------------------------------------------
>
>                 Key: HADOOP-6977
>                 URL: https://issues.apache.org/jira/browse/HADOOP-6977
>             Project: Hadoop Common
>          Issue Type: Improvement
>          Components: test
>    Affects Versions: 0.22.0
>            Reporter: Konstantin Boudnik
>            Assignee: Konstantin Boudnik
>         Attachments: FinderTest.java, HADOOP-6977.patch, HADOOP-6977.patch, HADOOP-6977.patch,
HADOOP-6977.y20S.patch, HADOOP-6977.y20S.patch
>
>
> The HDFS web user interface serves useful information through dfshealth.jsp and dfsnodelist.jsp.
> The Herriot interface to Hadoop cluster daemons would benefit from the addition of some
way to channel metics information.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message