hadoop-common-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Al Thompson (JIRA)" <j...@apache.org>
Subject [jira] Commented: (HADOOP-6977) Herriot daemon clients should vend statistics
Date Mon, 04 Oct 2010 21:30:35 GMT

    [ https://issues.apache.org/jira/browse/HADOOP-6977?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12917775#action_12917775
] 

Al Thompson commented on HADOOP-6977:
-------------------------------------

I have reviewed the patch in the most recent attachment. In doing so, it occurred to me that
the for loop to search for JMX options in the HADOOP_OPTS environment variable could be simplified.
This can be done by using either List.contains(..) or Arrays.binarySearch(..). The former
may be preferred, as the latter requires the collection to be sorted before invoking binarySearch().
I will attach a small sample that illustrates both of these.

I don't think changing this implementation will impact performance much, good or bad. IMHO
the code change would result in cleaner code and provide an examplar to other committers on
how not to re-implement the Java libraries in Hadoop code. 

> Herriot daemon clients should vend statistics
> ---------------------------------------------
>
>                 Key: HADOOP-6977
>                 URL: https://issues.apache.org/jira/browse/HADOOP-6977
>             Project: Hadoop Common
>          Issue Type: Improvement
>          Components: test
>    Affects Versions: 0.22.0
>            Reporter: Konstantin Boudnik
>            Assignee: Konstantin Boudnik
>         Attachments: HADOOP-6977.patch, HADOOP-6977.patch, HADOOP-6977.y20S.patch, HADOOP-6977.y20S.patch
>
>
> The HDFS web user interface serves useful information through dfshealth.jsp and dfsnodelist.jsp.
> The Herriot interface to Hadoop cluster daemons would benefit from the addition of some
way to channel metics information.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message