hadoop-common-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Konstantin Boudnik (JIRA)" <j...@apache.org>
Subject [jira] Commented: (HADOOP-6987) Use JUnit Rule to optionally fail test cases that run more than 10 seconds
Date Tue, 05 Oct 2010 00:58:32 GMT

    [ https://issues.apache.org/jira/browse/HADOOP-6987?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12917844#action_12917844
] 

Konstantin Boudnik commented on HADOOP-6987:
--------------------------------------------

Effectively, you offer to have a common class which has to be extended instead of having an
explicit statement like
{{@Rule public MethodRule globalTimeout = new Timeout(10 * 1000);}} in each test class which
needs to have a special timeout clause. I vouch that having an explicit {{@Rule}} statement
like above (if the same timeout applies for all class' cases) is clearer and doesn't require
inheritance. 

I think it worth noting [here|http://wiki.apache.org/hadoop/HowToDevelopUnitTests] about best
practices of timeout settings as soon as we'll agreed on the approach.

> Use JUnit Rule to optionally fail test cases that run more than 10 seconds
> --------------------------------------------------------------------------
>
>                 Key: HADOOP-6987
>                 URL: https://issues.apache.org/jira/browse/HADOOP-6987
>             Project: Hadoop Common
>          Issue Type: Improvement
>          Components: test
>    Affects Versions: 0.21.0
>            Reporter: Jakob Homan
>            Assignee: Jakob Homan
>             Fix For: 0.22.0
>
>         Attachments: HADOOP-6897.patch
>
>
> Using JUnit Rules annotations we can fail tests cases that take longer than 10 seconds
(for instance) to run.  This provides a regression check against test cases taking longer
than they had previously due to unintended code changes, as well as provides a membership
criteria for unit tests versus integration tests in HDFS and MR.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message