hadoop-common-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hairong Kuang (JIRA)" <j...@apache.org>
Subject [jira] Commented: (HADOOP-7009) MD5Hash provides a public factory method that creates an instance of MessageDigest
Date Thu, 28 Oct 2010 06:24:05 GMT

    [ https://issues.apache.org/jira/browse/HADOOP-7009?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12925707#action_12925707
] 

Hairong Kuang commented on HADOOP-7009:
---------------------------------------

     [exec] -1 overall.  
     [exec] 
     [exec]     +1 @author.  The patch does not contain any @author tags.
     [exec] 
     [exec]     -1 tests included.  The patch doesn't appe
     [exec] ar to include any new or modified tests.
     [exec]                         Please justify why no new tests are needed for this patch.
     [exec]                         Also please list what manual steps were performed to verify
this patch.
     [exec] 
     [exec]     -1 javadoc.  The javadoc tool appears to have generated 1 warning messages.
     [exec] 
     [exec]     +1 javac.  The applied patch does not increase the total number of javac compiler
warnings.
     [exec] 
     [exec]     +1 findbugs.  The patch does not introduce any new Findbugs warnings.
     [exec] 
     [exec]     +1 release audit.  The applied patch does not increase the total number of
release audit warnings.
     [exec] 
     [exec]     +1 system tests framework.  The patch passed system tests framework compile.
     [exec] 


> MD5Hash provides a public factory method that creates an instance of MessageDigest
> ----------------------------------------------------------------------------------
>
>                 Key: HADOOP-7009
>                 URL: https://issues.apache.org/jira/browse/HADOOP-7009
>             Project: Hadoop Common
>          Issue Type: Improvement
>          Components: io
>    Affects Versions: 0.22.0
>            Reporter: Hairong Kuang
>            Assignee: Hairong Kuang
>             Fix For: 0.22.0
>
>         Attachments: md5hash.patch, md5hash1.patch
>
>
> MD5Hash has a private way of creating a MessageDigest object that's thread local. I'd
like to have such a method which is public so that checksuming fsimage (HDFS-903) could use
it.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message