hadoop-common-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Eli Collins (JIRA)" <j...@apache.org>
Subject [jira] Commented: (HADOOP-7009) MD5Hash provides a public factory method that creates an instance of MessageDigest
Date Thu, 28 Oct 2010 02:25:20 GMT

    [ https://issues.apache.org/jira/browse/HADOOP-7009?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12925659#action_12925659
] 

Eli Collins commented on HADOOP-7009:
-------------------------------------

+1

Nit: getDigester needs a javadoc, and perhaps a name that suggests it returns a thread local?

> MD5Hash provides a public factory method that creates an instance of MessageDigest
> ----------------------------------------------------------------------------------
>
>                 Key: HADOOP-7009
>                 URL: https://issues.apache.org/jira/browse/HADOOP-7009
>             Project: Hadoop Common
>          Issue Type: Improvement
>          Components: io
>    Affects Versions: 0.22.0
>            Reporter: Hairong Kuang
>            Assignee: Hairong Kuang
>             Fix For: 0.22.0
>
>         Attachments: md5hash.patch
>
>
> MD5Hash has a private way of creating a MessageDigest object that's thread local. I'd
like to have such a method which is public so that checksuming fsimage (HDFS-903) could use
it.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message