hadoop-common-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Todd Lipcon (JIRA)" <j...@apache.org>
Subject [jira] Commented: (HADOOP-6818) Provide a JNI-based implementation of GroupMappingServiceProvider
Date Thu, 30 Sep 2010 17:11:34 GMT

    [ https://issues.apache.org/jira/browse/HADOOP-6818?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12916562#action_12916562
] 

Todd Lipcon commented on HADOOP-6818:
-------------------------------------

Hey Devaraj. Thanks for making the changes. One quick one: in the implementation of getGroupForUser()
I think it's possible that the cuser memory will be released twice. In the case that getGroupIDList
fails, CHECK_ERROR will call ReleaseStringUTFChars, and then the cleanup label will call it
again.

Is it possible to write a junit test case that ensures the results from the JNI mapping are
equivalent to the results from the ShellBased mapping? You can use junit's "assume" function
so that the tests only run when the native code is available.

> Provide a JNI-based implementation of GroupMappingServiceProvider
> -----------------------------------------------------------------
>
>                 Key: HADOOP-6818
>                 URL: https://issues.apache.org/jira/browse/HADOOP-6818
>             Project: Hadoop Common
>          Issue Type: Improvement
>          Components: security
>            Reporter: Devaraj Das
>            Assignee: Devaraj Das
>             Fix For: 0.22.0
>
>         Attachments: 6818-trunk.patch, hadoop-6818-1.patch, hadoop-6818-2.patch, JNIGroupMapping.patch
>
>
> The default implementation of GroupMappingServiceProvider does a fork of a unix command
to get the groups of a user. Since the group resolution happens in the servers, this might
be costly. This jira aims at providing a JNI-based implementation for GroupMappingServiceProvider.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message