hadoop-common-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Owen O'Malley (JIRA)" <j...@apache.org>
Subject [jira] Resolved: (HADOOP-6856) SequenceFile and MapFile need cleanup to remove redundant constructors
Date Thu, 30 Sep 2010 03:01:44 GMT

     [ https://issues.apache.org/jira/browse/HADOOP-6856?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Owen O'Malley resolved HADOOP-6856.
-----------------------------------

    Hadoop Flags: [Reviewed]
      Resolution: Fixed

I just committed this.

> SequenceFile and MapFile need cleanup to remove redundant constructors
> ----------------------------------------------------------------------
>
>                 Key: HADOOP-6856
>                 URL: https://issues.apache.org/jira/browse/HADOOP-6856
>             Project: Hadoop Common
>          Issue Type: Improvement
>          Components: io
>            Reporter: Owen O'Malley
>            Assignee: Owen O'Malley
>             Fix For: 0.22.0
>
>         Attachments: h-6856.patch, h-6856.patch
>
>
> Currently there are 2 public SequenceFile.Reader constructors, 3 public SequenceFile.Writer
constructors, 9 public SequenceFile.createWriter, 2 public MapFile.Reader constructors, and
8 public MapFile.Writer constructors. All of with various historical combinations of parameters
that don't cover the entire space.
> All of this makes it *very* difficult to add new optional parameters to SequenceFile
and MapFile. 
> I'd like change to the style of FileContext.create with option parameters. I'll implement
one public SequenceFile.Reader constructor and one public SequenceFile.createWriter and implement
all of the current variants based on those two. I'll do the same for MapFile.Reader and MapFile.Writer
including passing parameters down to the underlying SequenceFile.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message