Mailing-List: contact common-issues-help@hadoop.apache.org; run by ezmlm
Precedence: bulk
Reply-To: common-issues@hadoop.apache.org
Message-ID: <15439193.377111281994518895.JavaMail.jira@thor>
Date: Mon, 16 Aug 2010 17:35:18 -0400 (EDT)
From: "Konstantin Shvachko (JIRA)" <jira@apache.org>
To: common-issues@hadoop.apache.org
Subject: [jira] Commented: (HADOOP-6884) Add LOG.isDebugEnabled() guard for
 each LOG.debug("...")
In-Reply-To: <8688001.34681280270784520.JavaMail.jira@thor>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit


    [ https://issues.apache.org/jira/browse/HADOOP-6884?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12899104#action_12899104 ] 

Konstantin Shvachko commented on HADOOP-6884:
---------------------------------------------

Luke> The problem with the current approach is that you'd have to keep patching people's new code manually.

I understand that Erik has a script, which automates the process of finding calls to {{debug()}} unguarded with {{isDebugEnabled()}}. If we run it as a target of ant build, we can enforce people to maintain the guards automatically.

> Add LOG.isDebugEnabled() guard for each LOG.debug("...")
> --------------------------------------------------------
>
>                 Key: HADOOP-6884
>                 URL: https://issues.apache.org/jira/browse/HADOOP-6884
>             Project: Hadoop Common
>          Issue Type: Improvement
>    Affects Versions: 0.22.0
>            Reporter: Erik Steffl
>            Assignee: Erik Steffl
>             Fix For: 0.22.0
>
>         Attachments: HADOOP-6884-0.22-1.patch, HADOOP-6884-0.22.patch
>
>
> Each LOG.debug("...") should be executed only if LOG.isDebugEnabled() is true, in some cases it's expensive to construct the string that is being printed to log. It's much easier to always use LOG.isDebugEnabled() because it's easier to check (rather than in each case reason whether it's necessary or not).

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.