From common-issues-return-9931-apmail-hadoop-common-issues-archive=hadoop.apache.org@hadoop.apache.org Mon Aug 02 17:26:41 2010 Return-Path: Delivered-To: apmail-hadoop-common-issues-archive@minotaur.apache.org Received: (qmail 45964 invoked from network); 2 Aug 2010 17:26:41 -0000 Received: from unknown (HELO mail.apache.org) (140.211.11.3) by 140.211.11.9 with SMTP; 2 Aug 2010 17:26:41 -0000 Received: (qmail 96848 invoked by uid 500); 2 Aug 2010 17:26:41 -0000 Delivered-To: apmail-hadoop-common-issues-archive@hadoop.apache.org Received: (qmail 96757 invoked by uid 500); 2 Aug 2010 17:26:40 -0000 Mailing-List: contact common-issues-help@hadoop.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: common-issues@hadoop.apache.org Delivered-To: mailing list common-issues@hadoop.apache.org Received: (qmail 96743 invoked by uid 99); 2 Aug 2010 17:26:39 -0000 Received: from athena.apache.org (HELO athena.apache.org) (140.211.11.136) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 02 Aug 2010 17:26:39 +0000 X-ASF-Spam-Status: No, hits=-2000.0 required=10.0 tests=ALL_TRUSTED X-Spam-Check-By: apache.org Received: from [140.211.11.22] (HELO thor.apache.org) (140.211.11.22) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 02 Aug 2010 17:26:39 +0000 Received: from thor (localhost [127.0.0.1]) by thor.apache.org (8.13.8+Sun/8.13.8) with ESMTP id o72HQIdi002728 for ; Mon, 2 Aug 2010 17:26:19 GMT Message-ID: <26672875.119141280769978779.JavaMail.jira@thor> Date: Mon, 2 Aug 2010 13:26:18 -0400 (EDT) From: "Hairong Kuang (JIRA)" To: common-issues@hadoop.apache.org Subject: [jira] Updated: (HADOOP-6890) Improve listFiles API introduced by HADOOP-6870 In-Reply-To: <6227281.77781280442376526.JavaMail.jira@thor> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/HADOOP-6890?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Hairong Kuang updated HADOOP-6890: ---------------------------------- Attachment: improveListFiles.patch > Improve listFiles API introduced by HADOOP-6870 > ----------------------------------------------- > > Key: HADOOP-6890 > URL: https://issues.apache.org/jira/browse/HADOOP-6890 > Project: Hadoop Common > Issue Type: Improvement > Components: fs > Affects Versions: 0.22.0 > Reporter: Hairong Kuang > Assignee: Hairong Kuang > Fix For: 0.22.0 > > Attachments: improveListFiles.patch, listFilesInFS.patch > > > This jira is mainly for addressing Suresh's review comments for HADOOP-6870: > 1. General comment: I have concerns about recursive listing. This could be abused by the applications, creating a lot of requests into HDFS. > 2. Any deletion of files/directories while reursing through directories results in RuntimeException and application has a partial result. Should we ignore if a directory was in stack and was not found later when iterating through it? > 3. FileSystem.java > * listFile() - method javadoc could be better organized - first write about if path is directory and two cases recursive=true and false. Then if path is file and two cases recursive=true or false. > * listFile() - document throwing RuntimeException, UnsupportedOperationException and the possible cause. IOException is no longer thrown. > 4. TestListFiles.java > * testDirectory() - comments test empty directory and test directory with 1 file should be moved up to relevant sections of the test. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.