hadoop-common-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Erik Steffl (JIRA)" <j...@apache.org>
Subject [jira] Commented: (HADOOP-6884) Add LOG.isDebugEnabled() guard for each LOG.debug("...")
Date Sat, 28 Aug 2010 19:22:55 GMT

    [ https://issues.apache.org/jira/browse/HADOOP-6884?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12903877#action_12903877
] 

Erik Steffl commented on HADOOP-6884:
-------------------------------------

HADOOP-6884-0.22-1.patch 'ant test' and 'ant test-patch' results (ran manually because Hudson
is down).

Results of 'ant test':

BUILD SUCCESSFUL
Total time: 6 minutes 44 seconds

Results of 'ant test-patch':

     [exec] There appear to be 2 release audit warnings before the patch and 2 release audit
warnings after applying the patch.
     [exec]
     [exec]
     [exec]
     [exec]
     [exec] -1 overall.
     [exec]
     [exec]     +1 @author.  The patch does not contain any @author tags.
     [exec]
     [exec]     +1 tests included.  The patch appears to include 18 new or modified tests.
     [exec]
     [exec]     -1 javadoc.  The javadoc tool appears to have generated 1 warning messages.
     [exec]
     [exec]     +1 javac.  The applied patch does not increase the total number of javac compiler
warnings.
     [exec]
     [exec]     +1 findbugs.  The patch does not introduce any new Findbugs warnings.
     [exec]
     [exec]     +1 release audit.  The applied patch does not increase the total number of
release audit warnings.
     [exec]

Javadoc warnings are unrelated to the patch:

     [exec]   [javadoc] Constructing Javadoc information...
     [exec]   [javadoc] /home/steffl/work/svn.isDebugEnabled/common-trunk/src/java/org/apache/hadoop/security/SecurityUtil.java:39:
warning: sun.security.jgss.krb5.Krb5Util is Sun proprietary API and may be removed in a future
release
     [exec]   [javadoc] import sun.security.jgss.krb5.Krb5Util;
     [exec]   [javadoc]                              ^
     [exec]   [javadoc] /home/steffl/work/svn.isDebugEnabled/common-trunk/src/java/org/apache/hadoop/security/SecurityUtil.java:40:
warning: sun.security.krb5.Credentials is Sun proprietary API and may be removed in a future
release
     [exec]   [javadoc] import sun.security.krb5.Credentials;
     [exec]   [javadoc]                         ^
     [exec]   [javadoc] /home/steffl/work/svn.isDebugEnabled/common-trunk/src/java/org/apache/hadoop/security/SecurityUtil.java:41:
warning: sun.security.krb5.PrincipalName is Sun proprietary API and may be removed in a future
release
     [exec]   [javadoc] import sun.security.krb5.PrincipalName;
     [exec]   [javadoc]                         ^
     [exec]   [javadoc] /home/steffl/work/svn.isDebugEnabled/common-trunk/src/java/org/apache/hadoop/security/KerberosName.java:31:
warning: sun.security.krb5.Config is Sun proprietary API and may be removed in a future release
     [exec]   [javadoc] import sun.security.krb5.Config;
     [exec]   [javadoc]                         ^
     [exec]   [javadoc] /home/steffl/work/svn.isDebugEnabled/common-trunk/src/java/org/apache/hadoop/security/KerberosName.java:32:
warning: sun.security.krb5.KrbException is Sun proprietary API and may be removed in a future
release
     [exec]   [javadoc] import sun.security.krb5.KrbException;
     [exec]   [javadoc]                         ^
     [exec]   [javadoc] /home/steffl/work/svn.isDebugEnabled/common-trunk/src/java/org/apache/hadoop/security/KerberosName.java:81:
warning: sun.security.krb5.Config is Sun proprietary API and may be removed in a future release
     [exec]   [javadoc]   private static Config kerbConf;
     [exec]   [javadoc]                  ^
     [exec]   [javadoc] ExcludePrivateAnnotationsStandardDoclet
     [exec]   [javadoc] Standard Doclet version 1.6.0_06
     [exec]   [javadoc] Building tree for all the packages and classes...
     [exec]   [javadoc] Building index for all the packages and classes...
     [exec]   [javadoc] Building index for all classes...
     [exec]   [javadoc] Generating /home/steffl/work/svn.isDebugEnabled/common-trunk/build/docs/api/stylesheet.css...
     [exec]   [javadoc] 6 warnings


> Add LOG.isDebugEnabled() guard for each LOG.debug("...")
> --------------------------------------------------------
>
>                 Key: HADOOP-6884
>                 URL: https://issues.apache.org/jira/browse/HADOOP-6884
>             Project: Hadoop Common
>          Issue Type: Improvement
>    Affects Versions: 0.22.0
>            Reporter: Erik Steffl
>            Assignee: Erik Steffl
>             Fix For: 0.22.0
>
>         Attachments: FunAgain.java, FunAgain.java, HADOOP-6884-0.22-1.patch, HADOOP-6884-0.22.patch
>
>
> Each LOG.debug("...") should be executed only if LOG.isDebugEnabled() is true, in some
cases it's expensive to construct the string that is being printed to log. It's much easier
to always use LOG.isDebugEnabled() because it's easier to check (rather than in each case
reason whether it's necessary or not).

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message