hadoop-common-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hadoop QA (JIRA)" <j...@apache.org>
Subject [jira] Commented: (HADOOP-6890) Improve listFiles API introduced by HADOOP-6870
Date Mon, 02 Aug 2010 17:54:16 GMT

    [ https://issues.apache.org/jira/browse/HADOOP-6890?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12894621#action_12894621
] 

Hadoop QA commented on HADOOP-6890:
-----------------------------------

-1 overall.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12451056/improveListFiles.patch
  against trunk revision 980953.

    +1 @author.  The patch does not contain any @author tags.

    +1 tests included.  The patch appears to include 6 new or modified tests.

    -1 javadoc.  The javadoc tool appears to have generated 1 warning messages.

    +1 javac.  The applied patch does not increase the total number of javac compiler warnings.

    +1 findbugs.  The patch does not introduce any new Findbugs warnings.

    +1 release audit.  The applied patch does not increase the total number of release audit
warnings.

    -1 core tests.  The patch failed core unit tests.

    +1 contrib tests.  The patch passed contrib unit tests.

Test results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h4.grid.sp2.yahoo.net/655/testReport/
Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h4.grid.sp2.yahoo.net/655/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Checkstyle results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h4.grid.sp2.yahoo.net/655/artifact/trunk/build/test/checkstyle-errors.html
Console output: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h4.grid.sp2.yahoo.net/655/console

This message is automatically generated.

> Improve listFiles API introduced by HADOOP-6870
> -----------------------------------------------
>
>                 Key: HADOOP-6890
>                 URL: https://issues.apache.org/jira/browse/HADOOP-6890
>             Project: Hadoop Common
>          Issue Type: Improvement
>          Components: fs
>    Affects Versions: 0.22.0
>            Reporter: Hairong Kuang
>            Assignee: Hairong Kuang
>             Fix For: 0.22.0
>
>         Attachments: improveListFiles.patch, listFilesInFS.patch
>
>
> This jira is mainly for addressing Suresh's review comments for HADOOP-6870:
>    1. General comment: I have concerns about recursive listing. This could be abused
by the applications, creating a lot of requests into HDFS.
>    2. Any deletion of files/directories while reursing through directories results in
RuntimeException and application has a partial result. Should we ignore if a directory was
in stack and was not found later when iterating through it?
>    3. FileSystem.java
>           * listFile() - method javadoc could be better organized - first write about
if path is directory and two cases recursive=true and false. Then if path is file and two
cases recursive=true or false.
>           * listFile() - document throwing RuntimeException, UnsupportedOperationException
and the possible cause. IOException is no longer thrown.
>    4. TestListFiles.java
>           * testDirectory() - comments test empty directory and test directory with 1
file should be moved up to relevant sections of the test.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message