hadoop-common-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Steve Loughran (JIRA)" <j...@apache.org>
Subject [jira] Commented: (HADOOP-6194) Add service base class and tests to hadoop-common/util
Date Fri, 20 Aug 2010 12:52:19 GMT

    [ https://issues.apache.org/jira/browse/HADOOP-6194?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12900682#action_12900682
] 

Steve Loughran commented on HADOOP-6194:
----------------------------------------

Looks similar, as their basic lifecycle set of states matches fairly well, they have a stopping
state to describe slow shutdowns which could make sense. It's the same philosophy of how you
design a class to represent a subclassable service with a lifecycle that can be aggregated.

Their base class itself is a bit minimal, I like to record why something failed. "Failed"
isn't enough, exceptions are handy. I'd also like it to implement Closeable as that's generally
handy.

If consensus was to adopt the guava lib as yet-another-dependency, there's no reason why their
AbstractServiceBase couldn't be used, but I'd still want a HadoopServiceBase under this which
would be our base class and have extra methods in there. 

However, we don't need to rush to Guava just because we would gain a lot from having our own
service base class, be it our own or descended from the Guava one.  

> Add service base class and tests to hadoop-common/util
> ------------------------------------------------------
>
>                 Key: HADOOP-6194
>                 URL: https://issues.apache.org/jira/browse/HADOOP-6194
>             Project: Hadoop Common
>          Issue Type: New Feature
>          Components: util
>    Affects Versions: 0.21.0
>            Reporter: Steve Loughran
>            Assignee: Steve Loughran
>             Fix For: 0.22.0
>
>         Attachments: find-new-warnings, HADOOP-6194-1.patch, HADOOP-6194.patch, HADOOP-6194.patch
>
>
> For a service base class, we need to add to common
> # The Service class
> # A mock Service class (it's not in test, its in src/, because it helps in functional
tests downstream)
> # Unit tests
> This is the issue to cover this work

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message