hadoop-common-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Tsz Wo (Nicholas), SZE (JIRA)" <j...@apache.org>
Subject [jira] Commented: (HADOOP-6897) FileSystem#mkdirs(FileSystem, Path, FsPermission) should not call setPermission if mkdirs failled
Date Thu, 05 Aug 2010 16:23:20 GMT

    [ https://issues.apache.org/jira/browse/HADOOP-6897?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12895722#action_12895722
] 

Tsz Wo (Nicholas), SZE commented on HADOOP-6897:
------------------------------------------------

I think that the static mkdirs(..) is confusing to users.  There are only a few lines of codes
inside.  Why don't we just deprecate it now and remove it in the future?

In the meantime, we could update the javadoc as follows:
{code}
/** 
 * This method is equivalent to the following codes:
 *
 *    if (fs.mkdirs(dir)) {
 *      fs.setPermission(dir, permission);
 *      return true;
 *    }
 *    return false;
 */
{code}

> FileSystem#mkdirs(FileSystem, Path, FsPermission) should not call setPermission if mkdirs
failled
> -------------------------------------------------------------------------------------------------
>
>                 Key: HADOOP-6897
>                 URL: https://issues.apache.org/jira/browse/HADOOP-6897
>             Project: Hadoop Common
>          Issue Type: Bug
>    Affects Versions: 0.22.0
>            Reporter: Hairong Kuang
>            Assignee: Hairong Kuang
>             Fix For: 0.22.0
>
>         Attachments: mkdirs.patch
>
>
> Here is the piece of code that has the bug. fs.setPermission should not be called if
result is false.
> {code}
>   public static boolean mkdirs(FileSystem fs, Path dir, FsPermission permission)
>   throws IOException {
>     // create the directory using the default permission
>     boolean result = fs.mkdirs(dir);
>     // set its permission to be the supplied one
>     fs.setPermission(dir, permission);
>     return result;
>   }
> {code}

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message