hadoop-common-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Tsz Wo (Nicholas), SZE (JIRA)" <j...@apache.org>
Subject [jira] Commented: (HADOOP-6884) Add LOG.isDebugEnabled() guard for each LOG.debug("...")
Date Mon, 16 Aug 2010 21:11:18 GMT

    [ https://issues.apache.org/jira/browse/HADOOP-6884?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12899091#action_12899091
] 

Tsz Wo (Nicholas), SZE commented on HADOOP-6884:
------------------------------------------------

Thanks Scott for a nice [summary|https://issues.apache.org/jira/browse/HADOOP-6884?focusedCommentId=12899084&page=com.atlassian.jira.plugin.system.issuetabpanels%3Acomment-tabpanel#action_12899084].

Actually, #1 is subjective.  I don't think adding an if-statement per LOG.debug(..) make the
codes hard to read or maintain.  On the other hand, #2 is very important in production systems.
 Source-code/byte-code rewriting mentioned in #3 needs a lot of works.  Why don't we just
commit Erik's patch?

> Add LOG.isDebugEnabled() guard for each LOG.debug("...")
> --------------------------------------------------------
>
>                 Key: HADOOP-6884
>                 URL: https://issues.apache.org/jira/browse/HADOOP-6884
>             Project: Hadoop Common
>          Issue Type: Improvement
>    Affects Versions: 0.22.0
>            Reporter: Erik Steffl
>            Assignee: Erik Steffl
>             Fix For: 0.22.0
>
>         Attachments: HADOOP-6884-0.22-1.patch, HADOOP-6884-0.22.patch
>
>
> Each LOG.debug("...") should be executed only if LOG.isDebugEnabled() is true, in some
cases it's expensive to construct the string that is being printed to log. It's much easier
to always use LOG.isDebugEnabled() because it's easier to check (rather than in each case
reason whether it's necessary or not).

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message