hadoop-common-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Erik Steffl (JIRA)" <j...@apache.org>
Subject [jira] Commented: (HADOOP-6884) Add LOG.isDebugEnabled() guard for each LOG.debug("...")
Date Fri, 13 Aug 2010 21:34:17 GMT

    [ https://issues.apache.org/jira/browse/HADOOP-6884?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12898426#action_12898426
] 

Erik Steffl commented on HADOOP-6884:
-------------------------------------

Why not committing a simple patch now and work on a good solution later?

Luke: we all prefer fixing the tools. Consider the timeframe and effort required. In the meantime
we can have proposed patch as an intermediate solution. Leaving out test code doesn't change
the situation. Adding comments is also code bloat (code bloat is mostly relevant for people
reading the code) plus it's not guaranteed to work (isDebugEnabled() is guaranteed to work
but people will add a marker more or less randomly without considering price of debug call).

Scott: build time - means we wouldn't be able to enable debug at runtime, that's a significant
restriction compared to current state and limits troubleshooting capabilities.

I appreciate comments but how about separating a short term quick fix and long term proper
solution? At this point it's not clear what a proper solution is. If you want I'll file a
jira for long term solution so that we don't forget about it? I mean we probably spent more
time discussing this that it take to both create a patch and reverse it (once we have the
proper solution).

> Add LOG.isDebugEnabled() guard for each LOG.debug("...")
> --------------------------------------------------------
>
>                 Key: HADOOP-6884
>                 URL: https://issues.apache.org/jira/browse/HADOOP-6884
>             Project: Hadoop Common
>          Issue Type: Improvement
>    Affects Versions: 0.22.0
>            Reporter: Erik Steffl
>            Assignee: Erik Steffl
>             Fix For: 0.22.0
>
>         Attachments: HADOOP-6884-0.22-1.patch, HADOOP-6884-0.22.patch
>
>
> Each LOG.debug("...") should be executed only if LOG.isDebugEnabled() is true, in some
cases it's expensive to construct the string that is being printed to log. It's much easier
to always use LOG.isDebugEnabled() because it's easier to check (rather than in each case
reason whether it's necessary or not).

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message