Mailing-List: contact common-issues-help@hadoop.apache.org; run by ezmlm
Precedence: bulk
Reply-To: common-issues@hadoop.apache.org
Message-ID: <28918255.113891275422440006.JavaMail.jira@thor>
Date: Tue, 1 Jun 2010 16:00:40 -0400 (EDT)
From: "Eli Collins (JIRA)" <jira@apache.org>
To: common-issues@hadoop.apache.org
Subject: [jira] Commented: (HADOOP-6787) Factor out glob pattern code from
 FileContext and Filesystem
In-Reply-To: <2758661.46911274829813581.JavaMail.jira@thor>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit


    [ https://issues.apache.org/jira/browse/HADOOP-6787?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12874204#action_12874204 ] 

Eli Collins commented on HADOOP-6787:
-------------------------------------

Looks good.

Nit: not your change but public GlobFilter methods need javadocs, spaces in between the end of a method and start of the next.


> Factor out glob pattern code from FileContext and Filesystem
> ------------------------------------------------------------
>
>                 Key: HADOOP-6787
>                 URL: https://issues.apache.org/jira/browse/HADOOP-6787
>             Project: Hadoop Common
>          Issue Type: Improvement
>            Reporter: Luke Lu
>            Assignee: Luke Lu
>             Fix For: 0.22.0
>
>         Attachments: hadoop-6787-trunk-v1.patch, hadoop-6787-y20s-v1.patch
>
>
> The GlobFilter class (especially the error-prone setRegex method) is duplicated in both FileContext and Filesystem. And I'd like to be able to reuse the most of the setRegex code for glob pattern matching in metrics filter configurations.
> We could at least factor out the hairy setRegex code and package them into a GlobPattern class with a minimum compile method.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.