Return-Path: Delivered-To: apmail-hadoop-common-issues-archive@minotaur.apache.org Received: (qmail 87028 invoked from network); 12 Jun 2010 01:12:38 -0000 Received: from unknown (HELO mail.apache.org) (140.211.11.3) by 140.211.11.9 with SMTP; 12 Jun 2010 01:12:38 -0000 Received: (qmail 30698 invoked by uid 500); 12 Jun 2010 01:12:38 -0000 Delivered-To: apmail-hadoop-common-issues-archive@hadoop.apache.org Received: (qmail 30652 invoked by uid 500); 12 Jun 2010 01:12:38 -0000 Mailing-List: contact common-issues-help@hadoop.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: common-issues@hadoop.apache.org Delivered-To: mailing list common-issues@hadoop.apache.org Received: (qmail 30644 invoked by uid 99); 12 Jun 2010 01:12:38 -0000 Received: from nike.apache.org (HELO nike.apache.org) (192.87.106.230) by apache.org (qpsmtpd/0.29) with ESMTP; Sat, 12 Jun 2010 01:12:38 +0000 X-ASF-Spam-Status: No, hits=-2000.0 required=10.0 tests=ALL_TRUSTED X-Spam-Check-By: apache.org Received: from [140.211.11.22] (HELO thor.apache.org) (140.211.11.22) by apache.org (qpsmtpd/0.29) with ESMTP; Sat, 12 Jun 2010 01:12:36 +0000 Received: from thor (localhost [127.0.0.1]) by thor.apache.org (8.13.8+Sun/8.13.8) with ESMTP id o5C1CEu7001662 for ; Sat, 12 Jun 2010 01:12:14 GMT Message-ID: <27592332.57111276305134671.JavaMail.jira@thor> Date: Fri, 11 Jun 2010 21:12:14 -0400 (EDT) From: "Jakob Homan (JIRA)" To: common-issues@hadoop.apache.org Subject: [jira] Updated: (HADOOP-6682) NetUtils:normalizeHostName does not process hostnames starting with [a-f] correctly In-Reply-To: <1523422048.700531270511667229.JavaMail.jira@brutus.apache.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 X-Virus-Checked: Checked by ClamAV on apache.org [ https://issues.apache.org/jira/browse/HADOOP-6682?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jakob Homan updated HADOOP-6682: -------------------------------- Status: Open (was: Patch Available) I call bogus on the javadoc warning, since this patch doesn't affect that. Re-run Hudson for test failure. I don't see it on my machine, but let's see if it re-occurs. > NetUtils:normalizeHostName does not process hostnames starting with [a-f] correctly > ----------------------------------------------------------------------------------- > > Key: HADOOP-6682 > URL: https://issues.apache.org/jira/browse/HADOOP-6682 > Project: Hadoop Common > Issue Type: Bug > Components: io > Reporter: Jakob Homan > Attachments: HADOOP-6682-Y20.patch, HADOOP-6682.patch > > > public static String normalizeHostName(String name) { > if (Character.digit(name.charAt(0), 16) != -1) { > return name; > This code is attempting to short-circuit the hostname->ip resolution on the assumption that if name starts with a digit, it's already an ip address. This is of questionable value, but because it checks for a hex digit, it will fail on names starting with [a-f]. Such names will not be converted to an ip address, but be returned unchanged. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.