hadoop-common-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Luke Lu (JIRA)" <j...@apache.org>
Subject [jira] Commented: (HADOOP-6787) Factor out glob pattern code from FileContext and Filesystem
Date Wed, 02 Jun 2010 18:31:42 GMT

    [ https://issues.apache.org/jira/browse/HADOOP-6787?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12874722#action_12874722
] 

Luke Lu commented on HADOOP-6787:
---------------------------------

Yes, it does include some fixes.  Summary of changes:

* Fixed ^ usage outside [...] (HADOOP-6618)
* Made the pattern more POSIX compliant: support [!...] as well as [^...]
* Made it to generate less garbage while matching by using non-capturing group.
* Removed some unnecessary checks that would throw on valid POSIX glob patterns.
* Added more comprehensive unit tests for the glob pattern matching code.



> Factor out glob pattern code from FileContext and Filesystem
> ------------------------------------------------------------
>
>                 Key: HADOOP-6787
>                 URL: https://issues.apache.org/jira/browse/HADOOP-6787
>             Project: Hadoop Common
>          Issue Type: Improvement
>            Reporter: Luke Lu
>            Assignee: Luke Lu
>             Fix For: 0.22.0
>
>         Attachments: hadoop-6787-trunk-v1.patch, hadoop-6787-y20s-v1.patch
>
>
> The GlobFilter class (especially the error-prone setRegex method) is duplicated in both
FileContext and Filesystem. And I'd like to be able to reuse the most of the setRegex code
for glob pattern matching in metrics filter configurations.
> We could at least factor out the hairy setRegex code and package them into a GlobPattern
class with a minimum compile method.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message