hadoop-common-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hadoop QA (JIRA)" <j...@apache.org>
Subject [jira] Commented: (HADOOP-6803) Add native gzip read/write coverage to TestCodec
Date Thu, 03 Jun 2010 19:26:54 GMT

    [ https://issues.apache.org/jira/browse/HADOOP-6803?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12875261#action_12875261
] 

Hadoop QA commented on HADOOP-6803:
-----------------------------------

+1 overall.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12446204/hadoop-6803-2.patch
  against trunk revision 951081.

    +1 @author.  The patch does not contain any @author tags.

    +1 tests included.  The patch appears to include 3 new or modified tests.

    +1 javadoc.  The javadoc tool did not generate any warning messages.

    +1 javac.  The applied patch does not increase the total number of javac compiler warnings.

    +1 findbugs.  The patch does not introduce any new Findbugs warnings.

    +1 release audit.  The applied patch does not increase the total number of release audit
warnings.

    +1 core tests.  The patch passed core unit tests.

    +1 contrib tests.  The patch passed contrib unit tests.

Test results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h1.grid.sp2.yahoo.net/75/testReport/
Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h1.grid.sp2.yahoo.net/75/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Checkstyle results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h1.grid.sp2.yahoo.net/75/artifact/trunk/build/test/checkstyle-errors.html
Console output: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h1.grid.sp2.yahoo.net/75/console

This message is automatically generated.

> Add native gzip read/write coverage to TestCodec 
> -------------------------------------------------
>
>                 Key: HADOOP-6803
>                 URL: https://issues.apache.org/jira/browse/HADOOP-6803
>             Project: Hadoop Common
>          Issue Type: Test
>          Components: io
>    Affects Versions: 0.22.0
>            Reporter: Eli Collins
>            Assignee: Eli Collins
>             Fix For: 0.22.0
>
>         Attachments: hadoop-6803-1.patch, hadoop-6803-2.patch
>
>
> Looking at ZlibCompressor I noticed that the finished member is never modified, and is
therefore always false. This means ZlibCompressor#finished will always return false so CompressorStream#close
loops indefinitely in finish:
> {code} 
>       while (!compressor.finished()) {
>         compress();
>       }
> {code}
> I modifed TestCodec#testGzipCodecWrite to also cover writing using the native lib and
confirmed the hang with jstack. The fix is simple, ZlibCompressor should record when it's
been finished.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message