hadoop-common-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Luke Lu (JIRA)" <j...@apache.org>
Subject [jira] Commented: (HADOOP-6787) Factor out glob pattern code from FileContext and Filesystem
Date Wed, 02 Jun 2010 17:35:43 GMT

    [ https://issues.apache.org/jira/browse/HADOOP-6787?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12874689#action_12874689
] 

Luke Lu commented on HADOOP-6787:
---------------------------------

The main incentive for the refactor is to make the GlobPattern reusable by other components
(including but not limited to metrics configuration) in other packages (e.g., org.apache.hadoop.metrics).
I  proposed in private to make it reside in org.apache.hadoop.util as it's really a general
utility (a simplified and less powerful (than regex to shoot  people's foot easily) pattern
matching mechanism, as found in many other languages.), and met with strong resistance. So
it stays in the fs package, where it comes from. 

It seems to me that It should remain as a java public class, as it's needed by other packages,
but be annotated as audience private.

> Factor out glob pattern code from FileContext and Filesystem
> ------------------------------------------------------------
>
>                 Key: HADOOP-6787
>                 URL: https://issues.apache.org/jira/browse/HADOOP-6787
>             Project: Hadoop Common
>          Issue Type: Improvement
>            Reporter: Luke Lu
>            Assignee: Luke Lu
>             Fix For: 0.22.0
>
>         Attachments: hadoop-6787-trunk-v1.patch, hadoop-6787-y20s-v1.patch
>
>
> The GlobFilter class (especially the error-prone setRegex method) is duplicated in both
FileContext and Filesystem. And I'd like to be able to reuse the most of the setRegex code
for glob pattern matching in metrics filter configurations.
> We could at least factor out the hairy setRegex code and package them into a GlobPattern
class with a minimum compile method.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message