hadoop-common-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Luke Lu (JIRA)" <j...@apache.org>
Subject [jira] Updated: (HADOOP-6787) Factor out glob pattern code from FileContext and Filesystem
Date Thu, 03 Jun 2010 01:07:58 GMT

     [ https://issues.apache.org/jira/browse/HADOOP-6787?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Luke Lu updated HADOOP-6787:
----------------------------

     Issue Type: Bug  (was: Improvement)
    Description: 
Refactor the glob pattern code out of FileContext and FileSystem into a package private GlobFilter
and the reusable GlobPattern class (InterfaceAudience.Private)

Also fix the handling of ^ outside character class ([...]) reported in HADOOP-6618 and make
the glob pattern code less restrictive (not throwing on some valid glob patterns.) and more
POSIX standard compliant (support [!...]).

  was:
The GlobFilter class (especially the error-prone setRegex method) is duplicated in both FileContext
and Filesystem. And I'd like to be able to reuse the most of the setRegex code for glob pattern
matching in metrics filter configurations.

We could at least factor out the hairy setRegex code and package them into a GlobPattern class
with a minimum compile method.


Done.

> Factor out glob pattern code from FileContext and Filesystem
> ------------------------------------------------------------
>
>                 Key: HADOOP-6787
>                 URL: https://issues.apache.org/jira/browse/HADOOP-6787
>             Project: Hadoop Common
>          Issue Type: Bug
>          Components: fs
>            Reporter: Luke Lu
>            Assignee: Luke Lu
>             Fix For: 0.22.0
>
>         Attachments: hadoop-6787-trunk-v1.patch, hadoop-6787-trunk-v2.patch, hadoop-6787-y20s-v1.patch
>
>
> Refactor the glob pattern code out of FileContext and FileSystem into a package private
GlobFilter and the reusable GlobPattern class (InterfaceAudience.Private)
> Also fix the handling of ^ outside character class ([...]) reported in HADOOP-6618 and
make the glob pattern code less restrictive (not throwing on some valid glob patterns.) and
more POSIX standard compliant (support [!...]).

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message