Return-Path: Delivered-To: apmail-hadoop-common-issues-archive@minotaur.apache.org Received: (qmail 94340 invoked from network); 7 May 2010 09:03:15 -0000 Received: from unknown (HELO mail.apache.org) (140.211.11.3) by 140.211.11.9 with SMTP; 7 May 2010 09:03:15 -0000 Received: (qmail 91677 invoked by uid 500); 7 May 2010 09:03:15 -0000 Delivered-To: apmail-hadoop-common-issues-archive@hadoop.apache.org Received: (qmail 91560 invoked by uid 500); 7 May 2010 09:03:14 -0000 Mailing-List: contact common-issues-help@hadoop.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: common-issues@hadoop.apache.org Delivered-To: mailing list common-issues@hadoop.apache.org Received: (qmail 91552 invoked by uid 99); 7 May 2010 09:03:14 -0000 Received: from nike.apache.org (HELO nike.apache.org) (192.87.106.230) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 07 May 2010 09:03:14 +0000 X-ASF-Spam-Status: No, hits=-2000.0 required=10.0 tests=ALL_TRUSTED X-Spam-Check-By: apache.org Received: from [140.211.11.22] (HELO thor.apache.org) (140.211.11.22) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 07 May 2010 09:03:11 +0000 Received: from thor (localhost [127.0.0.1]) by thor.apache.org (8.13.8+Sun/8.13.8) with ESMTP id o4792ovO024060 for ; Fri, 7 May 2010 09:02:50 GMT Message-ID: <12342449.28371273222970092.JavaMail.jira@thor> Date: Fri, 7 May 2010 05:02:50 -0400 (EDT) From: "Hadoop QA (JIRA)" To: common-issues@hadoop.apache.org Subject: [jira] Commented: (HADOOP-6536) FileUtil.fullyDelete(dir) behavior is not defined when we pass a symlink as the argument In-Reply-To: <508958946.48471265176519280.JavaMail.jira@brutus.apache.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 X-Virus-Checked: Checked by ClamAV on apache.org [ https://issues.apache.org/jira/browse/HADOOP-6536?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12865089#action_12865089 ] Hadoop QA commented on HADOOP-6536: ----------------------------------- +1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12443923/HADOOP-6536.v1.patch against trunk revision 941662. +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 3 new or modified tests. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed core unit tests. +1 contrib tests. The patch passed contrib unit tests. Test results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h4.grid.sp2.yahoo.net/510/testReport/ Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h4.grid.sp2.yahoo.net/510/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Checkstyle results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h4.grid.sp2.yahoo.net/510/artifact/trunk/build/test/checkstyle-errors.html Console output: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h4.grid.sp2.yahoo.net/510/console This message is automatically generated. > FileUtil.fullyDelete(dir) behavior is not defined when we pass a symlink as the argument > ---------------------------------------------------------------------------------------- > > Key: HADOOP-6536 > URL: https://issues.apache.org/jira/browse/HADOOP-6536 > Project: Hadoop Common > Issue Type: Bug > Components: fs > Reporter: Amareshwari Sriramadasu > Assignee: Ravi Gummadi > Fix For: 0.22.0 > > Attachments: HADOOP-6536.patch, HADOOP-6536.v1.patch > > > FileUtil.fullyDelete(dir) deletes contents of sym-linked directory when we pass a symlink. If this is the behavior, it should be documented as so. > Or it should be changed not to delete the contents of the sym-linked directory. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.