hadoop-common-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Tom White (JIRA)" <j...@apache.org>
Subject [jira] Commented: (HADOOP-6585) Add FileStatus#isDirectory and isFile
Date Thu, 27 May 2010 23:07:36 GMT

    [ https://issues.apache.org/jira/browse/HADOOP-6585?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12872685#action_12872685
] 

Tom White commented on HADOOP-6585:
-----------------------------------

This looks ready to commit. +1

Minor nit - add @deprecated to FileStatus#isDir doc comment so that it shows up more clearly
in generated Javadoc.

> Add FileStatus#isDirectory and isFile
> -------------------------------------
>
>                 Key: HADOOP-6585
>                 URL: https://issues.apache.org/jira/browse/HADOOP-6585
>             Project: Hadoop Common
>          Issue Type: Improvement
>          Components: fs
>    Affects Versions: 0.21.0, 0.22.0
>            Reporter: Eli Collins
>            Assignee: Eli Collins
>            Priority: Blocker
>             Fix For: 0.21.0, 0.22.0
>
>         Attachments: hadoop-6585-1.patch, hadoop-6585-2.patch, hadoop-6585-3.patch, hadoop-6585-4.patch
>
>
> Per Sanjay's suggestion in HADOOP-6421 let's deprecate FileStatus#isDir() and add isDirectory()
and isFile() to compliment isSymlink. Currently clients assume !isDir() implies a file, which
is no longer true with symlinks. I'll file a separate jira to change the various uses of !isDir()
to be isFile() or isFile() or isSymlink() as appropriate.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message