hadoop-common-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hadoop QA (JIRA)" <j...@apache.org>
Subject [jira] Commented: (HADOOP-6690) FilterFileSystem doesn't overwrite setTimes
Date Tue, 20 Apr 2010 22:49:50 GMT

    [ https://issues.apache.org/jira/browse/HADOOP-6690?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12859107#action_12859107
] 

Hadoop QA commented on HADOOP-6690:
-----------------------------------

-1 overall.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12442315/HADOOP-6690.0.patch
  against trunk revision 934619.

    +1 @author.  The patch does not contain any @author tags.

    +1 tests included.  The patch appears to include 3 new or modified tests.

    +1 javadoc.  The javadoc tool did not generate any warning messages.

    -1 javac.  The applied patch generated 1028 javac compiler warnings (more than the trunk's
current 1024 warnings).

    +1 findbugs.  The patch does not introduce any new Findbugs warnings.

    +1 release audit.  The applied patch does not increase the total number of release audit
warnings.

    +1 core tests.  The patch passed core unit tests.

    +1 contrib tests.  The patch passed contrib unit tests.

Test results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h4.grid.sp2.yahoo.net/466/testReport/
Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h4.grid.sp2.yahoo.net/466/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Checkstyle results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h4.grid.sp2.yahoo.net/466/artifact/trunk/build/test/checkstyle-errors.html
Console output: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h4.grid.sp2.yahoo.net/466/console

This message is automatically generated.

> FilterFileSystem doesn't overwrite setTimes
> -------------------------------------------
>
>                 Key: HADOOP-6690
>                 URL: https://issues.apache.org/jira/browse/HADOOP-6690
>             Project: Hadoop Common
>          Issue Type: Bug
>    Affects Versions: 0.22.0
>            Reporter: Rodrigo Schmidt
>            Assignee: Rodrigo Schmidt
>             Fix For: 0.22.0
>
>         Attachments: HADOOP-6690.0.patch
>
>
> FilterFileSystem seems to be a little outdated and it doesn't implement a few methods
(setTimes being the most important one):
> - setTimes(Path, long, long)
> - copyFromLocalFile(boolean,boolean, Path, Path)
> - copyFromLocalFile(boolean, boolean, Path[], Path)
> - getUsed()
> - deleteOnExit()
> I'm not sure if all of these methods should be wrapped in FilterFileSystem, but given
its purpose, I would say the more the better. It would be great to have other people's opinions
about this.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message