hadoop-common-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Tom White (JIRA)" <j...@apache.org>
Subject [jira] Commented: (HADOOP-6194) Add service base class and tests to hadoop-common/util
Date Tue, 27 Apr 2010 14:10:33 GMT

    [ https://issues.apache.org/jira/browse/HADOOP-6194?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12861404#action_12861404
] 

Tom White commented on HADOOP-6194:
-----------------------------------

Some comments on the latest patch:

* Naming: maybe "LifecycleService" instead of "HadoopService"? "MockService" could be "MockLifecycleService".
* Also, just "State" instead of "ServiceState", so the full form would be "LifecycleService.State".
Some methods already refer to "State", while others refer to "ServiceState", so this change
would help make this more regular.
* Javadoc on line 44 of HadoopService is malformed.
* It's unclear what the unit test is testing - the code in HadoopService, or the code in MockService,
or both? In general, mocks are used as doubles for testing logic in the real class. Can the
code be changed to make the distinction clearer?
* As Chris pointed out, it would be good to know that a real service daemon works with this
base code.


> Add service base class and tests to hadoop-common/util
> ------------------------------------------------------
>
>                 Key: HADOOP-6194
>                 URL: https://issues.apache.org/jira/browse/HADOOP-6194
>             Project: Hadoop Common
>          Issue Type: New Feature
>          Components: util
>    Affects Versions: 0.21.0
>            Reporter: Steve Loughran
>            Assignee: Steve Loughran
>             Fix For: 0.22.0
>
>         Attachments: HADOOP-6194-1.patch, HADOOP-6194.patch
>
>
> For a service base class, we need to add to common
> # The Service class
> # A mock Service class (it's not in test, its in src/, because it helps in functional
tests downstream)
> # Unit tests
> This is the issue to cover this work

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message