hadoop-common-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Rodrigo Schmidt (JIRA)" <j...@apache.org>
Subject [jira] Commented: (HADOOP-6690) FilterFileSystem doesn't overwrite setTimes
Date Wed, 21 Apr 2010 00:24:50 GMT

    [ https://issues.apache.org/jira/browse/HADOOP-6690?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12859141#action_12859141
] 

Rodrigo Schmidt commented on HADOOP-6690:
-----------------------------------------

Eli, while I was creating TestFilterFs, I realized there was a number of methods that were
not being implemented. Some of them are quite suspicious like getUri(), getStatistics(), getHomeDirectory(),
... Can you please double check if FilterFs is fine without these methods. If it's not the
case, it would be better to create a separate JIRA for that.

Here is the complete list:

{code}
{
    public FSDataInputStream open(final Path f) { return null; }
    public void checkPath(Path path) { }
    public Statistics getStatistics() { return null; }
    public URI getUri() { return null; }
    public Path getHomeDirectory() { return null; }
    public void checkScheme(URI uri, String supportedScheme) { }
    public String getUriPath(final Path p) { return null; }
    public void renameInternal(final Path src, final Path dst, boolean overwrite) { }
    public FsStatus getFsStatus(final Path f) { return null; }
}
{code}

> FilterFileSystem doesn't overwrite setTimes
> -------------------------------------------
>
>                 Key: HADOOP-6690
>                 URL: https://issues.apache.org/jira/browse/HADOOP-6690
>             Project: Hadoop Common
>          Issue Type: Bug
>    Affects Versions: 0.22.0
>            Reporter: Rodrigo Schmidt
>            Assignee: Rodrigo Schmidt
>             Fix For: 0.22.0
>
>         Attachments: HADOOP-6690.0.patch
>
>
> FilterFileSystem seems to be a little outdated and it doesn't implement a few methods
(setTimes being the most important one):
> - setTimes(Path, long, long)
> - copyFromLocalFile(boolean,boolean, Path, Path)
> - copyFromLocalFile(boolean, boolean, Path[], Path)
> - getUsed()
> - deleteOnExit()
> I'm not sure if all of these methods should be wrapped in FilterFileSystem, but given
its purpose, I would say the more the better. It would be great to have other people's opinions
about this.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message