hadoop-common-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hadoop QA (JIRA)" <j...@apache.org>
Subject [jira] Commented: (HADOOP-6677) InterfaceAudience.LimitedPrivate should take a string not an enum
Date Wed, 07 Apr 2010 03:56:33 GMT

    [ https://issues.apache.org/jira/browse/HADOOP-6677?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12854322#action_12854322
] 

Hadoop QA commented on HADOOP-6677:
-----------------------------------

-1 overall.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12440988/HADOOP-6677.patch
  against trunk revision 931226.

    +1 @author.  The patch does not contain any @author tags.

    -1 tests included.  The patch doesn't appear to include any new or modified tests.
                        Please justify why no new tests are needed for this patch.
                        Also please list what manual steps were performed to verify this patch.

    +1 javadoc.  The javadoc tool did not generate any warning messages.

    +1 javac.  The applied patch does not increase the total number of javac compiler warnings.

    +1 findbugs.  The patch does not introduce any new Findbugs warnings.

    +1 release audit.  The applied patch does not increase the total number of release audit
warnings.

    +1 core tests.  The patch passed core unit tests.

    +1 contrib tests.  The patch passed contrib unit tests.

Test results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h4.grid.sp2.yahoo.net/444/testReport/
Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h4.grid.sp2.yahoo.net/444/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Checkstyle results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h4.grid.sp2.yahoo.net/444/artifact/trunk/build/test/checkstyle-errors.html
Console output: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h4.grid.sp2.yahoo.net/444/console

This message is automatically generated.

> InterfaceAudience.LimitedPrivate should take a string not an enum
> -----------------------------------------------------------------
>
>                 Key: HADOOP-6677
>                 URL: https://issues.apache.org/jira/browse/HADOOP-6677
>             Project: Hadoop Common
>          Issue Type: Bug
>    Affects Versions: 0.21.0
>            Reporter: Alan Gates
>            Assignee: Tom White
>            Priority: Minor
>         Attachments: HADOOP-6677.patch
>
>
> Trying to keep the list of all possible components sharing limited private interfaces
up to date is painful.  As other subprojects beyond HDFS and MR use this interface it will
only get worse (see PIG-1311).  If it is converted to a string other subprojects can use it
without requiring patches to common.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message