Return-Path: Delivered-To: apmail-hadoop-common-issues-archive@minotaur.apache.org Received: (qmail 53930 invoked from network); 12 Mar 2010 12:10:25 -0000 Received: from unknown (HELO mail.apache.org) (140.211.11.3) by 140.211.11.9 with SMTP; 12 Mar 2010 12:10:25 -0000 Received: (qmail 53986 invoked by uid 500); 12 Mar 2010 12:09:49 -0000 Delivered-To: apmail-hadoop-common-issues-archive@hadoop.apache.org Received: (qmail 53935 invoked by uid 500); 12 Mar 2010 12:09:48 -0000 Mailing-List: contact common-issues-help@hadoop.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: common-issues@hadoop.apache.org Delivered-To: mailing list common-issues@hadoop.apache.org Received: (qmail 53916 invoked by uid 99); 12 Mar 2010 12:09:48 -0000 Received: from athena.apache.org (HELO athena.apache.org) (140.211.11.136) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 12 Mar 2010 12:09:48 +0000 X-ASF-Spam-Status: No, hits=-2000.0 required=10.0 tests=ALL_TRUSTED X-Spam-Check-By: apache.org Received: from [140.211.11.140] (HELO brutus.apache.org) (140.211.11.140) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 12 Mar 2010 12:09:47 +0000 Received: from brutus.apache.org (localhost [127.0.0.1]) by brutus.apache.org (Postfix) with ESMTP id 5A5F8234C4C2 for ; Fri, 12 Mar 2010 12:09:27 +0000 (UTC) Message-ID: <1945441828.225431268395767369.JavaMail.jira@brutus.apache.org> Date: Fri, 12 Mar 2010 12:09:27 +0000 (UTC) From: "Michele (@pirroh) Catasta (JIRA)" To: common-issues@hadoop.apache.org Subject: [jira] Updated: (HADOOP-6578) Configuration should trim whitespace around a lot of value types In-Reply-To: <420098299.401991266618387947.JavaMail.jira@brutus.apache.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/HADOOP-6578?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michele (@pirroh) Catasta updated HADOOP-6578: ---------------------------------------------- Attachment: HADOOP-6578.patch Tests were failing because of a missing null check in getTrimmed(). Attached a new patch and re-submitted to Hudson. > Configuration should trim whitespace around a lot of value types > ---------------------------------------------------------------- > > Key: HADOOP-6578 > URL: https://issues.apache.org/jira/browse/HADOOP-6578 > Project: Hadoop Common > Issue Type: Improvement > Components: conf > Affects Versions: 0.22.0 > Reporter: Todd Lipcon > Assignee: Michele (@pirroh) Catasta > Priority: Minor > Attachments: HADOOP-6578.patch > > > I've seen multiple users make an error where they've listed some whitespace around a class name (eg for configuring a scheduler). This results in a ClassNotFoundException which is very hard to debug, as you don't notice the whitespace in the exception! We should simply trim the whitespace in Configuration.getClass and Configuration.getClasses to avoid this class of user error. > Similarly, we should trim in getInt, getLong, etc - anywhere that whitespace doesn't have semantic meaning we should be a little less strict on input. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.