hadoop-common-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Michele (@pirroh) Catasta (JIRA)" <j...@apache.org>
Subject [jira] Updated: (HADOOP-6578) Configuration should trim whitespace around a lot of value types
Date Wed, 03 Mar 2010 16:14:27 GMT

     [ https://issues.apache.org/jira/browse/HADOOP-6578?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Michele (@pirroh) Catasta updated HADOOP-6578:
----------------------------------------------

    Attachment: HADOOP-6578.patch

Attaching a trivial patch that takes care only of getClass* methods.

I took a look at all the getters in Configuration, and I think we can safely trim property
name also for:
getBoolean(), getFloat(), getInt(), getLong(). Let me know if I should extend the patch to
those (and even other) methods.

As per HADOOP-6133, I didn't add any test because: "No additional tests required - this code
path is exercised widely by all parts of Hadoop".

> Configuration should trim whitespace around a lot of value types
> ----------------------------------------------------------------
>
>                 Key: HADOOP-6578
>                 URL: https://issues.apache.org/jira/browse/HADOOP-6578
>             Project: Hadoop Common
>          Issue Type: Improvement
>          Components: conf
>    Affects Versions: 0.22.0
>            Reporter: Todd Lipcon
>            Priority: Minor
>         Attachments: HADOOP-6578.patch
>
>
> I've seen multiple users make an error where they've listed some whitespace around a
class name (eg for configuring a scheduler). This results in a ClassNotFoundException which
is very hard to debug, as you don't notice the whitespace in the exception! We should simply
trim the whitespace in Configuration.getClass and Configuration.getClasses to avoid this class
of user error.
> Similarly, we should trim in getInt, getLong, etc - anywhere that whitespace doesn't
have semantic meaning we should be a little less strict on input.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message