Mailing-List: contact common-issues-help@hadoop.apache.org; run by ezmlm
Precedence: bulk
Reply-To: common-issues@hadoop.apache.org
Message-ID: <1123535141.392491266600508050.JavaMail.jira@brutus.apache.org>
Date: Fri, 19 Feb 2010 17:28:28 +0000 (UTC)
From: "Sanjay Radia (JIRA)" <jira@apache.org>
To: common-issues@hadoop.apache.org
Subject: [jira] Commented: (HADOOP-6421) Symbolic links
In-Reply-To: <789869504.1260323298357.JavaMail.jira@brutus>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit


    [ https://issues.apache.org/jira/browse/HADOOP-6421?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12835839#action_12835839 ] 

Sanjay Radia commented on HADOOP-6421:
--------------------------------------

I missed that this breaks compatibility in a subtle way:
Negation of FileStatus#isDir() is normally used to see if the target is a file. This will now break if the target happens to be symlink.

I suggest we deprecate isDir(), remove isSymlink() and add new method that returns an enum.
Alternatively we could deprecate isDir() and add  isDirectory() and isFile();


> Symbolic links
> --------------
>
>                 Key: HADOOP-6421
>                 URL: https://issues.apache.org/jira/browse/HADOOP-6421
>             Project: Hadoop Common
>          Issue Type: New Feature
>            Reporter: Eli Collins
>            Assignee: Eli Collins
>         Attachments: symlink-25-common.patch, symlink-26-common.patch, symlink-26-common.patch, symlink24-common.patch, symlink27-common.patch, symlink28-common.patch, symlink29-common.patch, symlink29-common.patch, symlink29-common.patch, symlink30-common.patch, symlink31-common.patch, symlink32-common.patch, symlink33-common.patch, symlink34-common.patch, symlink35-common.patch, symlink36-common.patch, symlink37-common.patch, symlink38-common.patch, symlink39-common.patch
>
>
> Here's a jira for the common parts of HDFS-245, mostly changes to FileContext and AbstractFileSystem.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.