hadoop-common-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Sanjay Radia (JIRA)" <j...@apache.org>
Subject [jira] Commented: (HADOOP-6421) Symbolic links
Date Wed, 10 Feb 2010 23:26:28 GMT

    [ https://issues.apache.org/jira/browse/HADOOP-6421?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12832286#action_12832286
] 

Sanjay Radia commented on HADOOP-6421:
--------------------------------------

My final review comments on patch 37.
Thanks for addressing my previous comments; Thanks for declaring the exception; however you
missed/have mistakes on a few.

* Javadoc : FileContext#createSymLink
** you added more details in Javadoc but not the semantics of the operations 
** suggestion add:
*** The following operations follow (ie resolve through) the symlinks: open, set/getWorkingDir,
setReplication, setPermission,
   setOwner, setTimes, get/setFileChecksum, getFileStatus, isDirectory, isFile, listStatus,
getFileBlockLocations, getFsStatus.
*** The following operations follow *intermediate* symlinks in the path but not the *final*
leaf symlink:
    create/mkdir the leaf should not exit.
    delete, deleteOnExit removes the leaf symlink

* UnresolvedLinkException
** AbstractFileSystem#getServerDefaults should not throw the UnresolvedLinkException
** AbstractFileSystem#getLinkTarget  - should this throw UnresolvedLinkException?
** Why does Filterfs throw UnresolvedLinkException on only some of its methods with a path
name arg  and not all.

* RawLocalFs  and symlinks -- I missed this in my earlier comments. 
  RawLocalFs is suppose to support only volume root relative and dot relative symlinks  (links
to other file systems
are not supported). Noticed that you strip out the scheme -  instead throw an exception if
the link is to a different file system.
(You will also have to fix the test that takes advantage of this).

Some comments on tests in my next comment.

> Symbolic links
> --------------
>
>                 Key: HADOOP-6421
>                 URL: https://issues.apache.org/jira/browse/HADOOP-6421
>             Project: Hadoop Common
>          Issue Type: New Feature
>            Reporter: Eli Collins
>            Assignee: Eli Collins
>         Attachments: symlink-25-common.patch, symlink-26-common.patch, symlink-26-common.patch,
symlink24-common.patch, symlink27-common.patch, symlink28-common.patch, symlink29-common.patch,
symlink29-common.patch, symlink29-common.patch, symlink30-common.patch, symlink31-common.patch,
symlink32-common.patch, symlink33-common.patch, symlink34-common.patch, symlink35-common.patch,
symlink36-common.patch, symlink37-common.patch
>
>
> Here's a jira for the common parts of HDFS-245, mostly changes to FileContext and AbstractFileSystem.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message