hadoop-common-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hadoop QA (JIRA)" <j...@apache.org>
Subject [jira] Commented: (HADOOP-6554) DelegationTokenSecretManager lifecycle is inconsistent
Date Wed, 10 Feb 2010 20:42:31 GMT

    [ https://issues.apache.org/jira/browse/HADOOP-6554?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12832187#action_12832187
] 

Hadoop QA commented on HADOOP-6554:
-----------------------------------

-1 overall.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12435483/hadoop-6554.txt
  against trunk revision 908353.

    +1 @author.  The patch does not contain any @author tags.

    -1 tests included.  The patch doesn't appear to include any new or modified tests.
                        Please justify why no new tests are needed for this patch.
                        Also please list what manual steps were performed to verify this patch.

    +1 javadoc.  The javadoc tool did not generate any warning messages.

    +1 javac.  The applied patch does not increase the total number of javac compiler warnings.

    +1 findbugs.  The patch does not introduce any new Findbugs warnings.

    +1 release audit.  The applied patch does not increase the total number of release audit
warnings.

    +1 core tests.  The patch passed core unit tests.

    +1 contrib tests.  The patch passed contrib unit tests.

Test results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h4.grid.sp2.yahoo.net/352/testReport/
Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h4.grid.sp2.yahoo.net/352/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Checkstyle results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h4.grid.sp2.yahoo.net/352/artifact/trunk/build/test/checkstyle-errors.html
Console output: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h4.grid.sp2.yahoo.net/352/console

This message is automatically generated.

> DelegationTokenSecretManager lifecycle is inconsistent
> ------------------------------------------------------
>
>                 Key: HADOOP-6554
>                 URL: https://issues.apache.org/jira/browse/HADOOP-6554
>             Project: Hadoop Common
>          Issue Type: Bug
>    Affects Versions: 0.22.0
>            Reporter: Todd Lipcon
>            Assignee: Todd Lipcon
>         Attachments: hadoop-6554.txt, hdfs-967.txt
>
>
> FSNamesystem.dtSecretManager is initialized in FSNamesystem.initialize(), but not started
until activate(). In FSN.stop() it calls dtSecretManager.stopThreads so long as it's non-null,
but doesn't check that the threads have started (ie activate() may never have been called).
This causes an NPE in stopThreads()
> To fix this, stopThreads should check tokenRemoverThread against null before interrupting
it.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message