hadoop-common-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hemanth Yamijala (JIRA)" <j...@apache.org>
Subject [jira] Commented: (HADOOP-6531) add FileUtil.fullyDeleteContents(dir) api to delete contents of a directory
Date Tue, 02 Feb 2010 19:10:19 GMT

    [ https://issues.apache.org/jira/browse/HADOOP-6531?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12828721#action_12828721
] 

Hemanth Yamijala commented on HADOOP-6531:
------------------------------------------

I would improve the test cases just a little bit:

- Please check for return values of FileUtil.fullyDeleteContents and FileUtil.fullyDelete
in test case.
- Also add a failure test case for both fullyDelete and fullyDeleteContents. We can create
a new directory for which we turn off write permissions. Then fullyDelete and fullyDeleteContents
should both fail and we should get a false return value that can be checked.

Code changes seem fine to me.

> add FileUtil.fullyDeleteContents(dir) api to delete contents of a directory
> ---------------------------------------------------------------------------
>
>                 Key: HADOOP-6531
>                 URL: https://issues.apache.org/jira/browse/HADOOP-6531
>             Project: Hadoop Common
>          Issue Type: Improvement
>          Components: fs
>            Reporter: Amareshwari Sriramadasu
>            Assignee: Amareshwari Sriramadasu
>            Priority: Minor
>             Fix For: 0.22.0
>
>         Attachments: patch-6531-1.txt, patch-6531-2.txt, patch-6531.txt
>
>
> Add FileUtil.fullyDeleteContents(dir) api to delete contents of a directory, not directory
itself. This will be useful if we want to clear the contents of cwd.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message