hadoop-common-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Sanjay Radia (JIRA)" <j...@apache.org>
Subject [jira] Commented: (HADOOP-6421) Symbolic links
Date Wed, 03 Feb 2010 17:21:27 GMT

    [ https://issues.apache.org/jira/browse/HADOOP-6421?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12829150#action_12829150

Sanjay Radia commented on HADOOP-6421:

Feedback on patch patch 33, FileContextSymlinkBaseTest 

* setup should create the test dir.

* testCreateFileViaSymlink()
    it does not create the file via the symlink - file is created directly;  it is only read
via symlink.

* testCreateFileExistingLink
    rename to testCreateFileDirExitingLink
    add a mkdir that fails. 

* testCreateLinkUsingRelPath
  rename testCreateLinkToFileUsingRelPath to match with testCreateLinkToFileUsingXXX

* testCreateLinkToFileUsingXXX
      in  testCreateLinkToFileUsingAbsPath you read the file "using rel, abs, and qualified
   It would make sense to do that for the other two tests.

* testSetWDResolvesLink
   Uses a link with an  abs path.
   For this test it would worth adding test for all 3 symlinks (rel, abs, qual) since the
   code-path here is different than testCreateLinkUsingXXX and will not be covered by those

* Structure and coverage:
Noticed that testCreateLinkXX has tests for abs, relative and FQ links.
Most of the other tests use an abs link.
You also have separate tests that test relative, abs, FQ links but they only test specific
methods but not all.
So I am somewhat unclear about the structure of the tests in how they cover all 3 kinds of

* Use the test library - FileContextTestHelper.java - it will make your tests simpler.

> Symbolic links
> --------------
>                 Key: HADOOP-6421
>                 URL: https://issues.apache.org/jira/browse/HADOOP-6421
>             Project: Hadoop Common
>          Issue Type: New Feature
>            Reporter: Eli Collins
>            Assignee: Eli Collins
>         Attachments: symlink-25-common.patch, symlink-26-common.patch, symlink-26-common.patch,
symlink24-common.patch, symlink27-common.patch, symlink28-common.patch, symlink29-common.patch,
symlink29-common.patch, symlink29-common.patch, symlink30-common.patch, symlink31-common.patch,
symlink32-common.patch, symlink33-common.patch, symlink34-common.patch, symlink35-common.patch,
> Here's a jira for the common parts of HDFS-245, mostly changes to FileContext and AbstractFileSystem.

This message is automatically generated by JIRA.
You can reply to this email to add a comment to the issue online.

View raw message