hadoop-common-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hadoop QA (JIRA)" <j...@apache.org>
Subject [jira] Commented: (HADOOP-6489) Findbug report: LI_LAZY_INIT_STATIC, OBL_UNSATISFIED_OBLIGATION
Date Fri, 15 Jan 2010 22:00:54 GMT

    [ https://issues.apache.org/jira/browse/HADOOP-6489?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12800934#action_12800934
] 

Hadoop QA commented on HADOOP-6489:
-----------------------------------

-1 overall.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12430441/HADOOP-6489.1.patch
  against trunk revision 898740.

    +1 @author.  The patch does not contain any @author tags.

    -1 tests included.  The patch doesn't appear to include any new or modified tests.
                        Please justify why no new tests are needed for this patch.
                        Also please list what manual steps were performed to verify this patch.

    +1 javadoc.  The javadoc tool did not generate any warning messages.

    +1 javac.  The applied patch does not increase the total number of javac compiler warnings.

    +1 findbugs.  The patch does not introduce any new Findbugs warnings.

    +1 release audit.  The applied patch does not increase the total number of release audit
warnings.

    +1 core tests.  The patch passed core unit tests.

    +1 contrib tests.  The patch passed contrib unit tests.

Test results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h4.grid.sp2.yahoo.net/277/testReport/
Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h4.grid.sp2.yahoo.net/277/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Checkstyle results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h4.grid.sp2.yahoo.net/277/artifact/trunk/build/test/checkstyle-errors.html
Console output: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h4.grid.sp2.yahoo.net/277/console

This message is automatically generated.

> Findbug report: LI_LAZY_INIT_STATIC, OBL_UNSATISFIED_OBLIGATION
> ---------------------------------------------------------------
>
>                 Key: HADOOP-6489
>                 URL: https://issues.apache.org/jira/browse/HADOOP-6489
>             Project: Hadoop Common
>          Issue Type: Bug
>          Components: fs, io, util
>    Affects Versions: 0.22.0
>            Reporter: Erik Steffl
>            Assignee: Erik Steffl
>             Fix For: 0.22.0
>
>         Attachments: HADOOP-6489.1.patch, HDFS-6489.patch
>
>
> From findbug report:
> Method org.apache.hadoop.io.compress.CompressionCodecFactory.main(String[]) may fail
to clean up java.io.OutputStream
> Incorrect lazy initialization of static field org.apache.hadoop.fs.FileContext.localFsSingleton
in org.apache.hadoop.fs.FileContext.getLocalFSFileContext()
> Incorrect lazy initialization of static field org.apache.hadoop.util.ReflectionUtils.serialFactory
in org.apache.hadoop.util.ReflectionUtils.getFactory(Configuration)
> Given that these have simple fixes I think one bug is enough.
> This is from findbug 1.3.9 running on current trunk:
> Path: .
> URL: http://svn.apache.org/repos/asf/hadoop/common/trunk
> Repository Root: http://svn.apache.org/repos/asf
> Repository UUID: 13f79535-47bb-0310-9956-ffa450edef68
> Revision: 898558
> Node Kind: directory
> Schedule: normal
> Last Changed Author: tomwhite
> Last Changed Rev: 897023
> Last Changed Date: 2010-01-07 13:43:38 -0800 (Thu, 07 Jan 2010)

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message