hadoop-common-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Chris Douglas (JIRA)" <j...@apache.org>
Subject [jira] Updated: (HADOOP-5348) Create a ThrowableWritable for serializing exceptions robustly
Date Wed, 13 Jan 2010 12:21:54 GMT

     [ https://issues.apache.org/jira/browse/HADOOP-5348?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel

Chris Douglas updated HADOOP-5348:

    Status: Open  (was: Patch Available)

* This pattern in {{equals}} is unnecessarily convoluted:
+    return !(message != null
+        ? !message.equals(that.message)
+        : that.message != null);
Using tenary operators in {{if}} expressions is similarly over-elaborate.
* Throwables with cycles in causes will cause {{StackOverflowError}}; consider a max depth
* The clone and copy constructor aren't really required, but why not call super.clone()?
* Why a final class?

Again, I'm not sure this is a general type that needs to be included in the framework. The
issues it blocks (save the lifecycle work) have no code attached to them, making its utility
more difficult to ascertain. The latest patches to HDFS-326 and HADOOP-6194 also include this
code, and neither uses this class.

I'd suggest closing this as "won't fix" and link it as incorporated in the lifecycle work.

> Create a ThrowableWritable for serializing exceptions robustly
> --------------------------------------------------------------
>                 Key: HADOOP-5348
>                 URL: https://issues.apache.org/jira/browse/HADOOP-5348
>             Project: Hadoop Common
>          Issue Type: New Feature
>          Components: ipc
>    Affects Versions: 0.21.0
>            Reporter: Steve Loughran
>            Assignee: Steve Loughran
>             Fix For: 0.21.0
>         Attachments: HADOOP-5348-2.patch, hadoop-5348.patch, ThrowableWritable.java
> HADOOP-5201 and other issues would benefit from a stable representation of exceptions,
one that can be sent over the network, maybe pushed out to web UIs and which we can be 100%
sure that the far end will be able to handle if they have the hadoop-core JAR on their classpath.

This message is automatically generated by JIRA.
You can reply to this email to add a comment to the issue online.

View raw message